From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3BD215E8B; Mon, 30 Dec 2024 15:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735573921; cv=none; b=dUSIn4pb2TGQuGtGSJr8HcoK/pR1wUSlxbTP2zSIaaQ8L77Hmma3Ow63rA9vOqVWr1JXL3dpJ3uqrTm2XBQfz85hvGmAQidlnBlNYKK/CdtZ28CzHQCqWJ+9E1z8aie63kuOzMcluLiRhV0YS5XzXuFICUHK10bbDY0i2/QUtcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735573921; c=relaxed/simple; bh=H47To27T+A3NBjVJUtRjc4whAzqBx1F7Zru3EbZuzM4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iDnC22XRcfDdOV/rLMqX3kerJOjY96fae5JoPex3iOreHZ5x7Df8BRhs7zZzCAv2ieXVH1PEb688KUmQGCkUEXZ5EjpuiEfbnUqHvjhG7mvv6Rg8h+knTfyCwEtEsnpqM4vrdz1nGPlvdEIhLPAm+fxZBam1SWeBblUAyjWaJoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=n6/Xu1Lw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="n6/Xu1Lw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3374DC4CED0; Mon, 30 Dec 2024 15:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1735573921; bh=H47To27T+A3NBjVJUtRjc4whAzqBx1F7Zru3EbZuzM4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n6/Xu1LwSqh5hQCYxEDf60TMjLunsX7mfxB14VJAYEYUBrJDm/3WgmouWqcKz8DED Pd1OlXQ4KABvIIiz+JBeec7i/QHBsEI4FZtUFr9rPFuDAghUXxot1EptPrwZlBmzi0 ZofVJ6mEj6Ku/0TkCDy2reVpeMz64AlIKS0Z7HU4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+0aecfd34fb878546f3fd@syzkaller.appspotmail.com, Lizhi Xu , "Steven Rostedt (Google)" Subject: [PATCH 6.6 74/86] tracing: Prevent bad count for tracing_cpumask_write Date: Mon, 30 Dec 2024 16:43:22 +0100 Message-ID: <20241230154214.522297038@linuxfoundation.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241230154211.711515682@linuxfoundation.org> References: <20241230154211.711515682@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lizhi Xu commit 98feccbf32cfdde8c722bc4587aaa60ee5ac33f0 upstream. If a large count is provided, it will trigger a warning in bitmap_parse_user. Also check zero for it. Cc: stable@vger.kernel.org Fixes: 9e01c1b74c953 ("cpumask: convert kernel trace functions") Link: https://lore.kernel.org/20241216073238.2573704-1-lizhi.xu@windriver.com Reported-by: syzbot+0aecfd34fb878546f3fd@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=0aecfd34fb878546f3fd Tested-by: syzbot+0aecfd34fb878546f3fd@syzkaller.appspotmail.com Signed-off-by: Lizhi Xu Signed-off-by: Steven Rostedt (Google) Signed-off-by: Greg Kroah-Hartman --- kernel/trace/trace.c | 3 +++ 1 file changed, 3 insertions(+) --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -5331,6 +5331,9 @@ tracing_cpumask_write(struct file *filp, cpumask_var_t tracing_cpumask_new; int err; + if (count == 0 || count > KMALLOC_MAX_SIZE) + return -EINVAL; + if (!zalloc_cpumask_var(&tracing_cpumask_new, GFP_KERNEL)) return -ENOMEM;