From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: lanbincn@qq.com, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.15.y] iio: adc: rockchip_saradc: fix information leak in triggered buffer
Date: Wed, 15 Jan 2025 19:25:27 -0500 [thread overview]
Message-ID: <20250115154930-304504c5fec90893@stable.kernel.org> (raw)
In-Reply-To: <tencent_72F5138E2C8C53C3392D4E4DF0C796A48006@qq.com>
[ Sasha's backport helper bot ]
Hi,
The upstream commit SHA1 provided is correct: 38724591364e1e3b278b4053f102b49ea06ee17c
WARNING: Author mismatch between patch and upstream commit:
Backport author: lanbincn@qq.com
Commit author: Javier Carrasco<javier.carrasco.cruz@gmail.com>
Status in newer kernel trees:
6.12.y | Present (different SHA1: 4291becc8b99)
6.6.y | Present (different SHA1: 0b5e30f0aceb)
6.1.y | Not found
5.15.y | Not found
Note: The patch differs from the upstream commit:
---
1: 38724591364e ! 1: bc61bac32997 iio: adc: rockchip_saradc: fix information leak in triggered buffer
@@ Metadata
## Commit message ##
iio: adc: rockchip_saradc: fix information leak in triggered buffer
+ commit 38724591364e1e3b278b4053f102b49ea06ee17c upstream.
+
The 'data' local struct is used to push data to user space from a
triggered buffer, but it does not set values for inactive channels, as
it only uses iio_for_each_active_channel() to assign new values.
@@ Commit message
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://patch.msgid.link/20241125-iio_memset_scan_holes-v1-4-0cb6e98d895c@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
+ (cherry picked from commit 38724591364e1e3b278b4053f102b49ea06ee17c)
+ Signed-off-by: Bin Lan <lanbincn@qq.com>
## drivers/iio/adc/rockchip_saradc.c ##
@@ drivers/iio/adc/rockchip_saradc.c: static irqreturn_t rockchip_saradc_trigger_handler(int irq, void *p)
@@ drivers/iio/adc/rockchip_saradc.c: static irqreturn_t rockchip_saradc_trigger_ha
+ memset(&data, 0, sizeof(data));
+
- mutex_lock(&info->lock);
+ mutex_lock(&i_dev->mlock);
- iio_for_each_active_channel(i_dev, i) {
+ for_each_set_bit(i, i_dev->active_scan_mask, i_dev->masklength) {
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.15.y | Success | Success |
prev parent reply other threads:[~2025-01-16 0:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 10:40 FAILED: patch "[PATCH] iio: adc: rockchip_saradc: fix information leak in triggered" failed to apply to 5.15-stable tree gregkh
2025-01-15 11:20 ` [PATCH 5.15.y] iio: adc: rockchip_saradc: fix information leak in triggered buffer lanbincn
2025-01-16 0:25 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115154930-304504c5fec90893@stable.kernel.org \
--to=sashal@kernel.org \
--cc=lanbincn@qq.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox