From: Greg KH <gregkh@linuxfoundation.org>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: stable@vger.kernel.org, broonie@kernel.org, rafael@kernel.org,
demonsingur@gmail.com
Subject: Re: [PATCH 6.1.y] regmap: fix wrong backport
Date: Tue, 21 Jan 2025 14:27:21 +0100 [thread overview]
Message-ID: <2025012107-playmate-hulk-b0bb@gregkh> (raw)
In-Reply-To: <2025012144-whinny-haggler-9aba@gregkh>
On Tue, Jan 21, 2025 at 02:23:31PM +0100, Greg KH wrote:
> On Wed, Jan 15, 2025 at 03:32:44AM +0000, Tzung-Bi Shih wrote:
> > 48dc44f3c1af ("regmap: detach regmap from dev on regmap_exit")
> > wrongly backported upstream commit 3061e170381a.
> >
> > It should patch regmap_exit() instead of regmap_reinit_cache().
> >
> > Fixes: 48dc44f3c1af ("regmap: detach regmap from dev on regmap_exit")
> > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
> > ---
> > drivers/base/regmap/regmap.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> How about submitting a revert of the mistake and then the original
> commit properly backported as a patch series of 2 commits? That way it
> makes it more obvious what is happening here.
I've done the revert now, a fixed up backport would be appreciated now.
thanks
greg k-h
prev parent reply other threads:[~2025-01-21 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 3:32 [PATCH 6.1.y] regmap: fix wrong backport Tzung-Bi Shih
2025-01-16 0:25 ` Sasha Levin
2025-01-21 13:23 ` Greg KH
2025-01-21 13:27 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025012107-playmate-hulk-b0bb@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=demonsingur@gmail.com \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox