Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, Steve French <stfrench@microsoft.com>,
	Paulo Alcantara <pc@manguebit.com>
Subject: Re: Backport smb client fix for special files
Date: Sun, 26 Jan 2025 19:34:24 +0100	[thread overview]
Message-ID: <20250126183424.oumzbwflyunn75uv@pali> (raw)
In-Reply-To: <2025012647-implode-levitator-502a@gregkh>

On Sunday 26 January 2025 17:17:25 Greg KH wrote:
> On Sun, Jan 26, 2025 at 04:05:58PM +0100, Pali Rohár wrote:
> > Hello,
> > 
> > I would like to propose backporting this commit to stable releases:
> > https://git.kernel.org/torvalds/c/3681c74d342db75b0d641ba60de27bf73e16e66b
> > smb: client: handle lack of EA support in smb2_query_path_info()
> 
> Doesn't that need to go into a release first?

Ou, it really is not released yet. I was just rebasing my branch on top
of the Linus's master branch and somehow I thought that changes which
"git rebase" dropped from my branch were already released.

So sure, first the change needs to be released and then it could be
proposed for backporting.

> > It is fixing support for querying special files (fifo/socket/block/char)
> > over SMB2+ servers which do not support extended attributes and reparse
> > point at the same time on one inode, which applied for older Windows
> > servers (pre-Win10).
> > 
> > I think that commit should have line:
> > Fixes: ea41367b2a60 ("smb: client: introduce SMB2_OP_QUERY_WSL_EA")
> > 
> > Note that the mention commit depends on:
> > ca4b2c460743 ("fs/smb/client: avoid querying SMB2_OP_QUERY_WSL_EA for SMB3 POSIX")
> 
> So what exactly should the series of commits be that we backport and to
> what kernel tree(s)?

I would propose to backport these two commits (in this order):
ca4b2c460743 ("fs/smb/client: avoid querying SMB2_OP_QUERY_WSL_EA for SMB3 POSIX")
3681c74d342d ("smb: client: handle lack of EA support in smb2_query_path_info()")

into all stable branches which already contain this commit:
ea41367b2a60 ("smb: client: introduce SMB2_OP_QUERY_WSL_EA")

Hopefully it is clear now.

> thanks,
> 
> greg k-h

  reply	other threads:[~2025-01-26 18:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-26 15:05 Backport smb client fix for special files Pali Rohár
2025-01-26 16:17 ` Greg KH
2025-01-26 18:34   ` Pali Rohár [this message]
2025-01-30  8:48     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250126183424.oumzbwflyunn75uv@pali \
    --to=pali@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=pc@manguebit.com \
    --cc=stable@vger.kernel.org \
    --cc=stfrench@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox