Backport smb client fix for special files

Backport smb client fix for special files

[Pali Rohár]

Hello,

I would like to propose backporting this commit to stable releases:
https://git.kernel.org/torvalds/c/3681c74d342db75b0d641ba60de27bf73e16e66b
smb: client: handle lack of EA support in smb2_query_path_info()

It is fixing support for querying special files (fifo/socket/block/char)
over SMB2+ servers which do not support extended attributes and reparse
point at the same time on one inode, which applied for older Windows
servers (pre-Win10).

I think that commit should have line:
Fixes: ea41367b2a60 ("smb: client: introduce SMB2_OP_QUERY_WSL_EA")

Note that the mention commit depends on:
ca4b2c460743 ("fs/smb/client: avoid querying SMB2_OP_QUERY_WSL_EA for SMB3 POSIX")

Pali

Re: Backport smb client fix for special files

[Greg KH]

On Sun, Jan 26, 2025 at 04:05:58PM +0100, Pali Rohár wrote:
> Hello,
> 
> I would like to propose backporting this commit to stable releases:
> https://git.kernel.org/torvalds/c/3681c74d342db75b0d641ba60de27bf73e16e66b
> smb: client: handle lack of EA support in smb2_query_path_info()

Doesn't that need to go into a release first?

> It is fixing support for querying special files (fifo/socket/block/char)
> over SMB2+ servers which do not support extended attributes and reparse
> point at the same time on one inode, which applied for older Windows
> servers (pre-Win10).
> 
> I think that commit should have line:
> Fixes: ea41367b2a60 ("smb: client: introduce SMB2_OP_QUERY_WSL_EA")
> 
> Note that the mention commit depends on:
> ca4b2c460743 ("fs/smb/client: avoid querying SMB2_OP_QUERY_WSL_EA for SMB3 POSIX")

So what exactly should the series of commits be that we backport and to
what kernel tree(s)?

thanks,

greg k-h

Re: Backport smb client fix for special files

[Pali Rohár]

On Sunday 26 January 2025 17:17:25 Greg KH wrote:
> On Sun, Jan 26, 2025 at 04:05:58PM +0100, Pali Rohár wrote:
> > Hello,
> > 
> > I would like to propose backporting this commit to stable releases:
> > https://git.kernel.org/torvalds/c/3681c74d342db75b0d641ba60de27bf73e16e66b
> > smb: client: handle lack of EA support in smb2_query_path_info()
> 
> Doesn't that need to go into a release first?

Ou, it really is not released yet. I was just rebasing my branch on top
of the Linus's master branch and somehow I thought that changes which
"git rebase" dropped from my branch were already released.

So sure, first the change needs to be released and then it could be
proposed for backporting.

> > It is fixing support for querying special files (fifo/socket/block/char)
> > over SMB2+ servers which do not support extended attributes and reparse
> > point at the same time on one inode, which applied for older Windows
> > servers (pre-Win10).
> > 
> > I think that commit should have line:
> > Fixes: ea41367b2a60 ("smb: client: introduce SMB2_OP_QUERY_WSL_EA")
> > 
> > Note that the mention commit depends on:
> > ca4b2c460743 ("fs/smb/client: avoid querying SMB2_OP_QUERY_WSL_EA for SMB3 POSIX")
> 
> So what exactly should the series of commits be that we backport and to
> what kernel tree(s)?

I would propose to backport these two commits (in this order):
ca4b2c460743 ("fs/smb/client: avoid querying SMB2_OP_QUERY_WSL_EA for SMB3 POSIX")
3681c74d342d ("smb: client: handle lack of EA support in smb2_query_path_info()")

into all stable branches which already contain this commit:
ea41367b2a60 ("smb: client: introduce SMB2_OP_QUERY_WSL_EA")

Hopefully it is clear now.

> thanks,
> 
> greg k-h

Re: Backport smb client fix for special files

[Greg KH]

On Sun, Jan 26, 2025 at 07:34:24PM +0100, Pali Rohár wrote:
> On Sunday 26 January 2025 17:17:25 Greg KH wrote:
> > On Sun, Jan 26, 2025 at 04:05:58PM +0100, Pali Rohár wrote:
> > > Hello,
> > > 
> > > I would like to propose backporting this commit to stable releases:
> > > https://git.kernel.org/torvalds/c/3681c74d342db75b0d641ba60de27bf73e16e66b
> > > smb: client: handle lack of EA support in smb2_query_path_info()
> > 
> > Doesn't that need to go into a release first?
> 
> Ou, it really is not released yet. I was just rebasing my branch on top
> of the Linus's master branch and somehow I thought that changes which
> "git rebase" dropped from my branch were already released.
> 
> So sure, first the change needs to be released and then it could be
> proposed for backporting.
> 
> > > It is fixing support for querying special files (fifo/socket/block/char)
> > > over SMB2+ servers which do not support extended attributes and reparse
> > > point at the same time on one inode, which applied for older Windows
> > > servers (pre-Win10).
> > > 
> > > I think that commit should have line:
> > > Fixes: ea41367b2a60 ("smb: client: introduce SMB2_OP_QUERY_WSL_EA")
> > > 
> > > Note that the mention commit depends on:
> > > ca4b2c460743 ("fs/smb/client: avoid querying SMB2_OP_QUERY_WSL_EA for SMB3 POSIX")
> > 
> > So what exactly should the series of commits be that we backport and to
> > what kernel tree(s)?
> 
> I would propose to backport these two commits (in this order):
> ca4b2c460743 ("fs/smb/client: avoid querying SMB2_OP_QUERY_WSL_EA for SMB3 POSIX")
> 3681c74d342d ("smb: client: handle lack of EA support in smb2_query_path_info()")
> 
> into all stable branches which already contain this commit:
> ea41367b2a60 ("smb: client: introduce SMB2_OP_QUERY_WSL_EA")
> 
> Hopefully it is clear now.

Yes, now queued up properly, thanks!

greg k-h