From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4BE813C9C4; Wed, 5 Feb 2025 14:12:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738764773; cv=none; b=NhGozjRlZyojAmC7zvUgLSUH8D/bp/fnoqappYEiJqvv2H8CyrwYPex23FeTFQv+BOh37h85U7hGCI6/OHSESJZpVbCbFoVFL/d4Jfpfx/wVch3ViQn1zLEj2x1J5K9r1zeSgpfwoXDX3AnWNMZbLBvCLz4kfMuw3tYMPPkZpcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738764773; c=relaxed/simple; bh=zkkvxXf5OqS5fY0YBeTyDVJB5OnWuUbGUL5+oOmiYAI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eL/OhmGQN+jtMZIWwRLN+BUvjhZ3Fw+wUnbpA3q8+j5e17L8xqDHvJvFu0w3GpaTH0j3TEStRuVYqD8NVpPh7XDutZfqZ3hs1hZAMx3BDGHdfd9DQqQZnpl1HlBJq5XeNbWuqvTHSUQIJwAhSY43NKQI455J1I6UaEMY3Se1wDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OJS+ncF5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OJS+ncF5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C956AC4CED1; Wed, 5 Feb 2025 14:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1738764773; bh=zkkvxXf5OqS5fY0YBeTyDVJB5OnWuUbGUL5+oOmiYAI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OJS+ncF5MAsuJjAeK7YheCtsxUCnYNw7jyfaixkYou70mm7bj17Ac7d8rqc68a+Di 5WFp8PSoPExNkj1LiY8OQqWPHw5JlXAT0wH1j2ZOxxdyi7NNI/iDHdQcYIg61ZyD0t +1eHVRqLATZcdQR2PjythX6Dy8xpAuNbN8sBLujc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Leon Romanovsky , Sasha Levin Subject: [PATCH 6.6 203/393] RDMA/mlx4: Avoid false error about access to uninitialized gids array Date: Wed, 5 Feb 2025 14:42:02 +0100 Message-ID: <20250205134428.072538082@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250205134420.279368572@linuxfoundation.org> References: <20250205134420.279368572@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Leon Romanovsky [ Upstream commit 1f53d88cbb0dcc7df235bf6611ae632b254fccd8 ] Smatch generates the following false error report: drivers/infiniband/hw/mlx4/main.c:393 mlx4_ib_del_gid() error: uninitialized symbol 'gids'. Traditionally, we are not changing kernel code and asking people to fix the tools. However in this case, the fix can be done by simply rearranging the code to be more clear. Fixes: e26be1bfef81 ("IB/mlx4: Implement ib_device callbacks") Link: https://patch.msgid.link/6a3a1577463da16962463fcf62883a87506e9b62.1733233426.git.leonro@nvidia.com Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/mlx4/main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index 529db874d67c6..b1bbdcff631d5 100644 --- a/drivers/infiniband/hw/mlx4/main.c +++ b/drivers/infiniband/hw/mlx4/main.c @@ -351,7 +351,7 @@ static int mlx4_ib_del_gid(const struct ib_gid_attr *attr, void **context) struct mlx4_port_gid_table *port_gid_table; int ret = 0; int hw_update = 0; - struct gid_entry *gids; + struct gid_entry *gids = NULL; if (!rdma_cap_roce_gid_table(attr->device, attr->port_num)) return -EINVAL; @@ -389,10 +389,10 @@ static int mlx4_ib_del_gid(const struct ib_gid_attr *attr, void **context) } spin_unlock_bh(&iboe->lock); - if (!ret && hw_update) { + if (gids) ret = mlx4_ib_update_gids(gids, ibdev, attr->port_num); - kfree(gids); - } + + kfree(gids); return ret; } -- 2.39.5