From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BE4913C3F6; Wed, 5 Feb 2025 14:23:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738765408; cv=none; b=EQ0L2TFnXLmsH9Uiwb0hQ1xST4mskMXBujKjUoIJEX3OK4EcdDP+myjOs8WyPrxo8ABIuxfli4eRsI5XsdpQtJ3mTBr4gPK0sx+qdbQSLL5fk7HFaU+znKgi8b7o/q5Mrh1I1OBnfr89mNOq85i5ckVvbcIfCLjCDxI7dQxXrHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738765408; c=relaxed/simple; bh=yeAABee57wZsFRNzRMx+ULOkTut8kT2w8qJaqrWeRKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d5NvhJy3tS26R7PiF4d50A7LC5CXFQWcZ1Dim0YwsBYsggFK7+TwSKHXRyPmsbaSsTdxWYE2NBUkqpDjD7rZJBvcxyG86iacAmQamAyQD9G5pieyX6tbD0HaP+7tyFEHe0DxV0MuA71CoELqEBzmGZzqOJHc4ibSTPJrPLU757Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=z0ibJrUK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="z0ibJrUK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A565C4CED1; Wed, 5 Feb 2025 14:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1738765407; bh=yeAABee57wZsFRNzRMx+ULOkTut8kT2w8qJaqrWeRKI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z0ibJrUKpc8lX8GiBlnS/hlUMqX1bg5goZ3FvAHvq+Uu8aAYV2dLsNeWfsDelVK2K ZlgbAWRAsuqzd8Uv6LJBnVKVvCMA5fbRQLX2WmEhrfBe9j9RZ2xSlkDtbrsslS/j3j TsWGl/7osgW443qKpy4gq29pC1M6VeVI1Ge7Qhts= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bo Gan , Stephen Boyd , Sasha Levin Subject: [PATCH 6.12 217/590] clk: analogbits: Fix incorrect calculation of vco rate delta Date: Wed, 5 Feb 2025 14:39:32 +0100 Message-ID: <20250205134503.588726202@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250205134455.220373560@linuxfoundation.org> References: <20250205134455.220373560@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bo Gan [ Upstream commit d7f12857f095ef38523399d47e68787b357232f6 ] In wrpll_configure_for_rate() we try to determine the best PLL configuration for a target rate. However, in the loop where we try values of R, we should compare the derived `vco` with `target_vco_rate`. However, we were in fact comparing it with `target_rate`, which is actually after Q shift. This is incorrect, and sometimes can result in suboptimal clock rates. Fix it. Fixes: 7b9487a9a5c4 ("clk: analogbits: add Wide-Range PLL library") Signed-off-by: Bo Gan Link: https://lore.kernel.org/r/20240830061639.2316-1-ganboing@gmail.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/analogbits/wrpll-cln28hpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/analogbits/wrpll-cln28hpc.c b/drivers/clk/analogbits/wrpll-cln28hpc.c index 65d422a588e1f..9d178afc73bdd 100644 --- a/drivers/clk/analogbits/wrpll-cln28hpc.c +++ b/drivers/clk/analogbits/wrpll-cln28hpc.c @@ -292,7 +292,7 @@ int wrpll_configure_for_rate(struct wrpll_cfg *c, u32 target_rate, vco = vco_pre * f; } - delta = abs(target_rate - vco); + delta = abs(target_vco_rate - vco); if (delta < best_delta) { best_delta = delta; best_r = r; -- 2.39.5