[PATCH 5.4~6.13] MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as static

[PATCH 5.4~6.13] MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as static

[WangYuli]

commit ddd068d81445b17ac0bed084dfeb9e58b4df3ddd upstream.

Declare ftrace_get_parent_ra_addr() as static to suppress clang
compiler warning that 'no previous prototype'. This function is
not intended to be called from other parts.

Fix follow error with clang-19:

arch/mips/kernel/ftrace.c:251:15: error: no previous prototype for function 'ftrace_get_parent_ra_addr' [-Werror,-Wmissing-prototypes]
  251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
      |               ^
arch/mips/kernel/ftrace.c:251:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
  251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
      | ^
      | static
1 error generated.

Signed-off-by: WangYuli <wangyuli@uniontech.com>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 arch/mips/kernel/ftrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c
index 8c401e42301c..f39e85fd58fa 100644
--- a/arch/mips/kernel/ftrace.c
+++ b/arch/mips/kernel/ftrace.c
@@ -248,7 +248,7 @@ int ftrace_disable_ftrace_graph_caller(void)
 #define S_R_SP	(0xafb0 << 16)	/* s{d,w} R, offset(sp) */
 #define OFFSET_MASK	0xffff	/* stack offset range: 0 ~ PT_SIZE */
 
-unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
+static unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long
 		old_parent_ra, unsigned long parent_ra_addr, unsigned long fp)
 {
 	unsigned long sp, ip, tmp;
-- 
2.47.2

Re: [PATCH 5.4~6.13] MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as static

[Sasha Levin]

[ Sasha's backport helper bot ]

Hi,

The upstream commit SHA1 provided is correct: ddd068d81445b17ac0bed084dfeb9e58b4df3ddd


Status in newer kernel trees:
6.13.y | Not found

Note: The patch differs from the upstream commit:
---
1:  ddd068d81445b ! 1:  9778a7c87d16c MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as static
    @@ Metadata
      ## Commit message ##
         MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as static
     
    +    commit ddd068d81445b17ac0bed084dfeb9e58b4df3ddd upstream.
    +
         Declare ftrace_get_parent_ra_addr() as static to suppress clang
         compiler warning that 'no previous prototype'. This function is
         not intended to be called from other parts.
    @@ Commit message
         Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
         Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
         Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    +    Signed-off-by: WangYuli <wangyuli@uniontech.com>
     
      ## arch/mips/kernel/ftrace.c ##
     @@ arch/mips/kernel/ftrace.c: int ftrace_disable_ftrace_graph_caller(void)
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.13.y       |  Success    |  Failed    |
| stable/linux-5.4.y        |  Success    |  Success   |

Build Errors:
Build error for stable/linux-6.13.y:
    during RTL pass: dfinit
    drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c: In function 'dml_core_mode_support':
    drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c:9217:1: internal compiler error: Segmentation fault
     9217 | }
          | ^
    x86_64-linux-gcc: internal compiler error: Segmentation fault signal terminated program cc1
    Please submit a full bug report, with preprocessed source (by using -freport-bug).
    See <https://gcc.gnu.org/bugs/> for instructions.
    make[6]: *** [scripts/Makefile.build:194: drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.o] Error 4
    make[6]: Target 'drivers/gpu/drm/amd/amdgpu/' not remade because of errors.
    make[5]: *** [scripts/Makefile.build:440: drivers/gpu/drm/amd/amdgpu] Error 2
    make[5]: Target 'drivers/gpu/drm/' not remade because of errors.
    make[4]: *** [scripts/Makefile.build:440: drivers/gpu/drm] Error 2
    make[4]: Target 'drivers/gpu/' not remade because of errors.
    make[3]: *** [scripts/Makefile.build:440: drivers/gpu] Error 2
    make[3]: Target 'drivers/' not remade because of errors.
    make[2]: *** [scripts/Makefile.build:440: drivers] Error 2
    make[2]: Target './' not remade because of errors.
    make[1]: *** [/home/sasha/build/linus-next/Makefile:1989: .] Error 2
    make[1]: Target '__all' not remade because of errors.
    make: *** [Makefile:251: __sub-make] Error 2
    make: Target '__all' not remade because of errors.