From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C17D14B08C for ; Mon, 10 Feb 2025 13:58:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739195895; cv=none; b=KkgcN5pnuqV+D4T+iO00gyWCE8Xj2eyJCuFGKTsOZEzQMvSKTZ6fBbbcBSGQyUTJ1kTTOWqvCth/0IrA10/v2OwACPYlvVc+2z1RFJN+KyiNes8NrFUSAsR+W9dKSfg0psX4r6jblAxM3YR7dRObkneCZGYqWi3YtKmq0SUl3x4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739195895; c=relaxed/simple; bh=1kbEseP809uMP1ea+LGy4OcLlgDPrTmbsbHPCLViXFQ=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=lUic2t3jpTjatZp043tlJsUT6nXKj4RDEJ1TBVDj3VJtlsJU+8j3PgtpRRlyM4gY/BS2BDGUll1Wy5WyTH8C5NRecqTdMXMJL6tFNowWyrRPbwwhKtA9RimrySeEDMFdTm5OENJSQOHOoWV51s9ZMEa9sfhoL0aJhj5z+3jQJwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tgZNNsAA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tgZNNsAA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1A6AC4CED1; Mon, 10 Feb 2025 13:58:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739195895; bh=1kbEseP809uMP1ea+LGy4OcLlgDPrTmbsbHPCLViXFQ=; h=Subject:To:Cc:From:Date:From; b=tgZNNsAAuVM9kcU5jFJPp3bsJBd2OOooM7kMuRpxKlg9qi5B/IYqisM1IxKH6e+ac GyUHhxoilYjTn0Zw2EcPNAOytfnBbPpYlxGtPG0kqj1TMuKj9vstt/Ge2b5uAqMRwY aEp8jILwSv8urw+pr8mEvohQiTauRytorSkaox90= Subject: FAILED: patch "[PATCH] scsi: core: Do not retry I/Os during depopulation" failed to apply to 6.6-stable tree To: ipylypiv@google.com,martin.petersen@oracle.com Cc: From: Date: Mon, 10 Feb 2025 14:58:12 +0100 Message-ID: <2025021012-engross-wildcat-b35d@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x 9ff7c383b8ac0c482a1da7989f703406d78445c6 # git commit -s git send-email --to '' --in-reply-to '2025021012-engross-wildcat-b35d@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 9ff7c383b8ac0c482a1da7989f703406d78445c6 Mon Sep 17 00:00:00 2001 From: Igor Pylypiv Date: Fri, 31 Jan 2025 10:44:07 -0800 Subject: [PATCH] scsi: core: Do not retry I/Os during depopulation Fail I/Os instead of retry to prevent user space processes from being blocked on the I/O completion for several minutes. Retrying I/Os during "depopulation in progress" or "depopulation restore in progress" results in a continuous retry loop until the depopulation completes or until the I/O retry loop is aborted due to a timeout by the scsi_cmd_runtime_exceeced(). Depopulation is slow and can take 24+ hours to complete on 20+ TB HDDs. Most I/Os in the depopulation retry loop end up taking several minutes before returning the failure to user space. Cc: stable@vger.kernel.org # 4.18.x: 2bbeb8d scsi: core: Handle depopulation and restoration in progress Cc: stable@vger.kernel.org # 4.18.x Fixes: e37c7d9a0341 ("scsi: core: sanitize++ in progress") Signed-off-by: Igor Pylypiv Link: https://lore.kernel.org/r/20250131184408.859579-1-ipylypiv@google.com Signed-off-by: Martin K. Petersen diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index d776f13cd160..be0890e4e706 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -872,13 +872,18 @@ static void scsi_io_completion_action(struct scsi_cmnd *cmd, int result) case 0x1a: /* start stop unit in progress */ case 0x1b: /* sanitize in progress */ case 0x1d: /* configuration in progress */ - case 0x24: /* depopulation in progress */ - case 0x25: /* depopulation restore in progress */ action = ACTION_DELAYED_RETRY; break; case 0x0a: /* ALUA state transition */ action = ACTION_DELAYED_REPREP; break; + /* + * Depopulation might take many hours, + * thus it is not worthwhile to retry. + */ + case 0x24: /* depopulation in progress */ + case 0x25: /* depopulation restore in progress */ + fallthrough; default: action = ACTION_FAIL; break;