From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6638D241139 for ; Tue, 18 Feb 2025 12:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739880462; cv=none; b=QdCW3ZpIXzKACw5Gr8XIQaFzUAk70Pv8rjM908nBiBdV9rhEMGK2mfcF/X29PSpRuEdWRZPFMLeSItfDBcbSyqqbgMp3TwyzEJMj6OMKzrVTyhBEBDxiFUpIKu/m68RDIES4tDQzVK+0dQCMP8Gid3oqo3OKlxJOgdHK95SFiBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739880462; c=relaxed/simple; bh=8SNzP+yXojbFfx8v0cdyiNccGF2m6MYsU4C2n3v8ay0=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=n2p/yX9RtWp3zKE2YgbyMJlomAGAIi9gteQXxwcAJOfRA8wFvf2RWqF4poyGgzCzeiDOdtbGRBXCtU68ev33nqHg61wC7ay649ov9ab8tvouKuiYuYtywKjGh6nRE1Ew5CAAZMjIQpeBSbmUKIgHK3uo8mmArLmK9WOsvgKM1YU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jNPpNinH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jNPpNinH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7311EC4CEE6; Tue, 18 Feb 2025 12:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739880461; bh=8SNzP+yXojbFfx8v0cdyiNccGF2m6MYsU4C2n3v8ay0=; h=Subject:To:Cc:From:Date:From; b=jNPpNinHcovVirR28oDsuWKdyjgxcTAWeRREhj8OtVp2QWkg2cvSi0MC+0XXMIjn4 3iqcpxSoXxm+c5SHthlzFooTvN7LpKTOFnT77e/MkNm4VErMnnfMwlpkkEqkarGzBx yd91prrNbgVGWGX19/JZ1imIEdsSK8x6SaRwpfcs= Subject: FAILED: patch "[PATCH] USB: gadget: f_midi: f_midi_complete to call queue_work" failed to apply to 6.6-stable tree To: jilliandonahue58@gmail.com,gregkh@linuxfoundation.org,stable@kernel.org Cc: From: Date: Tue, 18 Feb 2025 13:07:30 +0100 Message-ID: <2025021830-phantom-negligent-416a@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y git checkout FETCH_HEAD git cherry-pick -x 4ab37fcb42832cdd3e9d5e50653285ca84d6686f # git commit -s git send-email --to '' --in-reply-to '2025021830-phantom-negligent-416a@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 4ab37fcb42832cdd3e9d5e50653285ca84d6686f Mon Sep 17 00:00:00 2001 From: Jill Donahue Date: Tue, 11 Feb 2025 10:48:05 -0700 Subject: [PATCH] USB: gadget: f_midi: f_midi_complete to call queue_work When using USB MIDI, a lock is attempted to be acquired twice through a re-entrant call to f_midi_transmit, causing a deadlock. Fix it by using queue_work() to schedule the inner f_midi_transmit() via a high priority work queue from the completion handler. Link: https://lore.kernel.org/all/CAArt=LjxU0fUZOj06X+5tkeGT+6RbXzpWg1h4t4Fwa_KGVAX6g@mail.gmail.com/ Fixes: d5daf49b58661 ("USB: gadget: midi: add midi function driver") Cc: stable Signed-off-by: Jill Donahue Link: https://lore.kernel.org/r/20250211174805.1369265-1-jdonahue@fender.com Signed-off-by: Greg Kroah-Hartman diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c index 47260d65066a..da82598fcef8 100644 --- a/drivers/usb/gadget/function/f_midi.c +++ b/drivers/usb/gadget/function/f_midi.c @@ -283,7 +283,7 @@ f_midi_complete(struct usb_ep *ep, struct usb_request *req) /* Our transmit completed. See if there's more to go. * f_midi_transmit eats req, don't queue it again. */ req->length = 0; - f_midi_transmit(midi); + queue_work(system_highpri_wq, &midi->work); return; } break;