From: Greg KH <gregkh@linuxfoundation.org>
To: jaywang-amazon <wanjay@amazon.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 6.1 1/1] x86/i8253: Disable PIT timer 0 when not in use
Date: Tue, 18 Feb 2025 08:17:52 +0100 [thread overview]
Message-ID: <2025021834-overdrawn-rely-d929@gregkh> (raw)
In-Reply-To: <20250217225353.21795-4-wanjay@amazon.com>
On Mon, Feb 17, 2025 at 10:53:55PM +0000, jaywang-amazon wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> Leaving the PIT interrupt running can cause noticeable steal time for
> virtual guests. The VMM generally has a timer which toggles the IRQ input
> to the PIC and I/O APIC, which takes CPU time away from the guest. Even
> on real hardware, running the counter may use power needlessly (albeit
> not much).
>
> Make sure it's turned off if it isn't going to be used.
>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Michael Kelley <mhkelley@outlook.com>
> Link: https://lore.kernel.org/all/20240802135555.564941-1-dwmw2@infradead.org
>
> (cherry picked from commit 70e6b7d9ae3c63df90a7bba7700e8d5c300c3c60)
> Cc: stable@vger.kernel.org #v6.1
> Signed-off-by: jaywang-amazon <wanjay@amazon.com>
We need a real name, not a fake-company name please.
thanks,
greg k-h
prev parent reply other threads:[~2025-02-18 7:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 22:53 [PATCH 6.1 0/1] Backport upstream commit 70e6b7d9ae3c63df90a7bba7700e8d5c300c3c60 to stable 6.1 jaywang-amazon
2025-02-17 22:53 ` [PATCH 6.1 1/1] x86/i8253: Disable PIT timer 0 when not in use jaywang-amazon
2025-02-18 7:17 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025021834-overdrawn-rely-d929@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=wanjay@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox