From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B28421DFE39; Wed, 19 Feb 2025 08:52:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739955126; cv=none; b=mSbgiS5snNp5iS5x7plU+8Ha68LXM9QFFpT0mcxFHFs3YUHDX4OBpTzt9WxKofkhNyca+XtrWhUliVYF2VBVyo7C89tXnYFcM0YgHM1+vC3Dos0ZVQXhjV3mS/NCeEcV21p+2z++1Ux4ldlXbEZhtyfQul8jNNR8Zho0/1WKbqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739955126; c=relaxed/simple; bh=1qG/3kwR2vCSFPEwqpAtgIX9uh3vJemB+HYs9o4+6gs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uwc8QcIVR2N1sRxvcigAANFvxclJqAZ++2YdRYx4+l3RyLfVt/YhaZcsqYWJsVLTL0WwyUq29Kyq3tyaate1jtkAt6sOpw5y/UFjiZo9TqMdxy1564fIreskBdo4D+Sa/KZFTKbpEhD4tL/JC+65mxhW2Gud6yPMXJLWseW0zXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HFUgB9Qo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HFUgB9Qo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F802C4CEE6; Wed, 19 Feb 2025 08:52:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739955126; bh=1qG/3kwR2vCSFPEwqpAtgIX9uh3vJemB+HYs9o4+6gs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HFUgB9QolghlqCz5koibdXpEKe9nFGVVVVxLYW4MoMVQo/X8y0pQU22lIs4NIYvFy iCnkcO8th4wQZXqH7B81f+0nN80SuHVX3dkqxX2mdTC6mtAIPtrkp3wxu4wecEtFX/ cy5bh1Ub3JkHB4AVoP6vGQZwjwFM+TqzGOndLje4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yutaro Ohno , Alice Ryhl , Miguel Ojeda Subject: [PATCH 6.12 141/230] rust: rbtree: fix overindented list item Date: Wed, 19 Feb 2025 09:27:38 +0100 Message-ID: <20250219082607.202571990@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250219082601.683263930@linuxfoundation.org> References: <20250219082601.683263930@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Miguel Ojeda commit 2e4f982cf392af2f1282b5537a72144e064799e3 upstream. Starting with Rust 1.86.0 (to be released 2025-04-03), Clippy will have a new lint, `doc_overindented_list_items` [1], which catches cases of overindented list items. The lint has been added by Yutaro Ohno, based on feedback from the kernel [2] on a patch that fixed a similar case -- commit 0c5928deada1 ("rust: block: fix formatting in GenDisk doc"). Clippy reports a few cases in the kernel, apart from the one already fixed in the commit above. One is this one: error: doc list item overindented --> rust/kernel/rbtree.rs:1152:5 | 1152 | /// null, it is a pointer to the root of the [`RBTree`]. | ^^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items = note: `-D clippy::doc-overindented-list-items` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::doc_overindented_list_items)]` Thus clean it up. Cc: Yutaro Ohno Cc: stable@vger.kernel.org # Needed in 6.12.y and 6.13.y only (Rust is pinned in older LTSs). Fixes: a335e9591404 ("rust: rbtree: add `RBTree::entry`") Link: https://github.com/rust-lang/rust-clippy/pull/13711 [1] Link: https://github.com/rust-lang/rust-clippy/issues/13601 [2] Reviewed-by: Alice Ryhl Reviewed-by: Yutaro Ohno Link: https://lore.kernel.org/r/20250206232022.599998-1-ojeda@kernel.org [ There are a few other cases, so updated message. - Miguel ] Signed-off-by: Miguel Ojeda Signed-off-by: Greg Kroah-Hartman --- rust/kernel/rbtree.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/rust/kernel/rbtree.rs +++ b/rust/kernel/rbtree.rs @@ -1147,7 +1147,7 @@ pub struct VacantEntry<'a, K, V> { /// # Invariants /// - `parent` may be null if the new node becomes the root. /// - `child_field_of_parent` is a valid pointer to the left-child or right-child of `parent`. If `parent` is -/// null, it is a pointer to the root of the [`RBTree`]. +/// null, it is a pointer to the root of the [`RBTree`]. struct RawVacantEntry<'a, K, V> { rbtree: *mut RBTree, /// The node that will become the parent of the new node if we insert one.