From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B70081DE2CA; Wed, 19 Feb 2025 09:27:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739957258; cv=none; b=h8QXuSacuQKy3DyEobgbso9mpV3aGhYvpdyqKXviBhgC9HGxyd9GveSQzoTAlppfjirjhGruB94akw/+68m6du3FEknz4+qVTFjpQxKOXZ1nix709lBSfypUKyU7PIcaK95fMD8ZwJV71mxNIC7YisCV9iv/mTZzRFkDVdFbM/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739957258; c=relaxed/simple; bh=I4T6ii8k9Rsuq2yzzzGFaNI4GxZ6pV6Lu0qb0d6HMAE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nCYmPGfuthAkThWffuhrYaclHMvRQrJLWwe23nHSy8tEIN6e5TOh33wrVq5KQ4faw7xqooVmWLywPLLmJYlZmsaca7fB3ezBhDkrn1HZYR+fariFaArJxQSlCeWUc/6kgBe7cF1mrr6jj1CMA0gD3ofB5esMTwSWyvJUiMs8gAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=W2Spy4ex; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="W2Spy4ex" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CED03C4CED1; Wed, 19 Feb 2025 09:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739957258; bh=I4T6ii8k9Rsuq2yzzzGFaNI4GxZ6pV6Lu0qb0d6HMAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W2Spy4exnOQ8Cspw0BbAEWP5Owzr3BS0lqGjP1S8S4Lj6eqWcGohYpgFPSkB3JY3O j0XWfpMG5F06X3uNdiqyQug9jc0q8ABCMgHm7UEwWnD1X4eblYO4ar4sXvT0DC+g6W 48fJh7IE8C/0ra7K218iw7Cgo4tt7CZkmkyupDWg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andy Shevchenko , Linus Walleij , Sasha Levin Subject: [PATCH 6.1 464/578] pinctrl: cy8c95x0: Respect IRQ trigger settings from firmware Date: Wed, 19 Feb 2025 09:27:48 +0100 Message-ID: <20250219082711.257924151@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250219082652.891560343@linuxfoundation.org> References: <20250219082652.891560343@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andy Shevchenko [ Upstream commit 1ddee69108d305bbc059cbf31c0b47626796be77 ] Some of the platforms may connect the INT pin via inversion logic effectively make the triggering to be active-low. Remove explicit trigger flag to respect the settings from firmware. Without this change even idling chip produces spurious interrupts and kernel disables the line in the result: irq 33: nobody cared (try booting with the "irqpoll" option) CPU: 0 UID: 0 PID: 125 Comm: irq/33-i2c-INT3 Not tainted 6.12.0-00236-g8b874ed11dae #64 Hardware name: Intel Corp. QUARK/Galileo, BIOS 0x01000900 01/01/2014 ... handlers: [<86e86bea>] irq_default_primary_handler threaded [] cy8c95x0_irq_handler [pinctrl_cy8c95x0] Disabling IRQ #33 Fixes: e6cbbe42944d ("pinctrl: Add Cypress cy8c95x0 support") Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/20250117142304.596106-2-andriy.shevchenko@linux.intel.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/pinctrl-cy8c95x0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c index 5abab6bc763ae..f7c8ae9808133 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -1234,7 +1234,7 @@ static int cy8c95x0_irq_setup(struct cy8c95x0_pinctrl *chip, int irq) ret = devm_request_threaded_irq(chip->dev, irq, NULL, cy8c95x0_irq_handler, - IRQF_ONESHOT | IRQF_SHARED | IRQF_TRIGGER_HIGH, + IRQF_ONESHOT | IRQF_SHARED, dev_name(chip->dev), chip); if (ret) { dev_err(chip->dev, "failed to request irq %d\n", irq); -- 2.39.5