From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Xiangyu Chen <xiangyu.chen@eng.windriver.com>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.1] Squashfs: check the inode number is not the invalid value of zero
Date: Thu, 27 Feb 2025 23:56:12 -0500 [thread overview]
Message-ID: <20250227142317-7980cd9af3d37985@stable.kernel.org> (raw)
In-Reply-To: <20250226081646.1983643-1-xiangyu.chen@eng.windriver.com>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: 9253c54e01b6505d348afbc02abaa4d9f8a01395
WARNING: Author mismatch between patch and upstream commit:
Backport author: Xiangyu Chen<xiangyu.chen@eng.windriver.com>
Commit author: Phillip Lougher<phillip@squashfs.org.uk>
Status in newer kernel trees:
6.13.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (different SHA1: be383effaee3)
Note: The patch differs from the upstream commit:
---
1: 9253c54e01b65 ! 1: fee0f4eb6fa1f Squashfs: check the inode number is not the invalid value of zero
@@ Metadata
## Commit message ##
Squashfs: check the inode number is not the invalid value of zero
+ [ upstream commit 9253c54e01b6505d348afbc02abaa4d9f8a01395 ]
+
Syskiller has produced an out of bounds access in fill_meta_index().
That out of bounds access is ultimately caused because the inode
@@ Commit message
Cc: Christian Brauner <brauner@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
+ Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com>
+ Signed-off-by: He Zhe <zhe.he@windriver.com>
## fs/squashfs/inode.c ##
@@ fs/squashfs/inode.c: static int squashfs_new_inode(struct super_block *sb, struct inode *inode,
@@ fs/squashfs/inode.c: static int squashfs_new_inode(struct super_block *sb, struc
i_uid_write(inode, i_uid);
i_gid_write(inode, i_gid);
- inode->i_ino = le32_to_cpu(sqsh_ino->inode_number);
- inode_set_mtime(inode, le32_to_cpu(sqsh_ino->mtime), 0);
- inode_set_atime(inode, inode_get_mtime_sec(inode), 0);
- inode_set_ctime(inode, inode_get_mtime_sec(inode), 0);
+ inode->i_mtime.tv_sec = le32_to_cpu(sqsh_ino->mtime);
+ inode->i_atime.tv_sec = inode->i_mtime.tv_sec;
+ inode->i_ctime.tv_sec = inode->i_mtime.tv_sec;
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.1.y | Success | Success |
prev parent reply other threads:[~2025-02-28 4:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 8:16 [PATCH 6.1] Squashfs: check the inode number is not the invalid value of zero Xiangyu Chen
2025-02-27 5:08 ` Sasha Levin
2025-02-28 4:56 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227142317-7980cd9af3d37985@stable.kernel.org \
--to=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xiangyu.chen@eng.windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox