From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, ribalda@chromium.org
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.1.y] media: uvcvideo: Fix crash during unbind if gpio unit is in use
Date: Fri, 28 Feb 2025 23:20:49 -0500 [thread overview]
Message-ID: <20250228171523-c7b680aa3c63684f@stable.kernel.org> (raw)
In-Reply-To: <20250228075228.2623486-1-ribalda@chromium.org>
[ Sasha's backport helper bot ]
Hi,
Summary of potential issues:
⚠️ Found matching upstream commit but patch is missing proper reference to it
Found matching upstream commit: a9ea1a3d88b7947ce8cadb2afceee7a54872bbc5
Status in newer kernel trees:
6.13.y | Present (different SHA1: 5d2e65cbe53d)
6.12.y | Present (different SHA1: d2eac8b14ac6)
6.6.y | Present (different SHA1: 0b5e0445bc83)
Note: The patch differs from the upstream commit:
---
1: a9ea1a3d88b79 ! 1: 459a9ebcbed5f media: uvcvideo: Fix crash during unbind if gpio unit is in use
@@ Commit message
Link: https://lore.kernel.org/r/20241106-uvc-crashrmmod-v6-1-fbf9781c6e83@chromium.org
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
+ (cherry picked from commit a9ea1a3d88b7947ce8cadb2afceee7a54872bbc5)
## drivers/media/usb/uvc/uvc_driver.c ##
@@ drivers/media/usb/uvc/uvc_driver.c: static int uvc_gpio_parse(struct uvc_device *dev)
@@ drivers/media/usb/uvc/uvc_driver.c: static int uvc_gpio_parse(struct uvc_device
return PTR_ERR_OR_ZERO(gpio_privacy);
irq = gpiod_to_irq(gpio_privacy);
- if (irq < 0)
-- return dev_err_probe(&dev->udev->dev, irq,
+- if (irq < 0) {
+- if (irq != EPROBE_DEFER)
+- dev_err(&dev->udev->dev,
+- "No IRQ for privacy GPIO (%d)\n", irq);
+- return irq;
+- }
++ if (irq < 0)
+ return dev_err_probe(&dev->intf->dev, irq,
- "No IRQ for privacy GPIO\n");
++ "No IRQ for privacy GPIO\n");
- unit = uvc_alloc_new_entity(dev, UVC_EXT_GPIO_UNIT,
+ unit = uvc_alloc_entity(UVC_EXT_GPIO_UNIT, UVC_EXT_GPIO_UNIT_ID, 0, 1);
+ if (!unit)
@@ drivers/media/usb/uvc/uvc_driver.c: static int uvc_gpio_parse(struct uvc_device *dev)
static int uvc_gpio_init_irq(struct uvc_device *dev)
{
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.1.y | Success | Success |
prev parent reply other threads:[~2025-03-01 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 15:11 FAILED: patch "[PATCH] media: uvcvideo: Fix crash during unbind if gpio unit is in" failed to apply to 6.1-stable tree gregkh
2025-02-28 7:52 ` [PATCH 6.1.y] media: uvcvideo: Fix crash during unbind if gpio unit is in use Ricardo Ribalda
2025-03-01 4:20 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228171523-c7b680aa3c63684f@stable.kernel.org \
--to=sashal@kernel.org \
--cc=ribalda@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox