From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 921EB19C542; Wed, 5 Mar 2025 18:12:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741198357; cv=none; b=V8hYjPyJxb2tzV0T1/Dcu9dTX5BzHgXAz4q+GKtEiSX6E2QRCXgB+3EtnfL0P/XzdUiLk5owKokySoIoQajsBBQmEJphQIsLqANICnQv92zJXTSdzIdqPCoH24lg5a59W3ei1e1+Dxn8kbMBPuJywOdvtPmBE6w/JO6QBQeer84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741198357; c=relaxed/simple; bh=xb4AkyOT5G1Den3G3MgKLLnJ1Lem3dFdHda84rCCkDI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z8NSZVFwxhhjWHrfe8LLI23ntGa+AbZZyR8I+fAEJAx/6XsbDI/PcREfMjkXe3EqbCCXZI1VFErQ7eVmcN9R57dMbM2ZIxJGTmFeAofG3axnsvQBPDbZFLy7X8TuXqsVPiU2iUOPTqcRHovjpGkbX5lPOy5NGn9I5OmncAu8Fhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CNedvmDK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CNedvmDK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17EF5C4CED1; Wed, 5 Mar 2025 18:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741198357; bh=xb4AkyOT5G1Den3G3MgKLLnJ1Lem3dFdHda84rCCkDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CNedvmDKypt056R42hbJ8TcNjFmJbrvChmCD0H75kJwL7LWa1MO/3WKvXmyJ6+6x2 vmW2/bN+CCH/8jI+D5LKwYH3K43JH0IpnQJfmozcLBSdcXMtpYqwtqH6V+GSLOnBwa V1uXdthqW1g/al4rL/RdRO75hGX10AvSFBWXvWEQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, George Moussalem , Christian Marangi , Andrew Lunn , Jakub Kicinski Subject: [PATCH 6.12 110/150] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT Date: Wed, 5 Mar 2025 18:48:59 +0100 Message-ID: <20250305174508.234484895@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250305174503.801402104@linuxfoundation.org> References: <20250305174503.801402104@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: George Moussalem commit 992ee3ed6e9fdd0be83a7daa5ff738e3cf86047f upstream. While setting the DAC value, the wrong boolean value is evaluated to set the DSP bias current. So let's correct the conditional statement and use the right boolean value read from the DTS set in the priv. Cc: stable@vger.kernel.org Fixes: d1cb613efbd3 ("net: phy: qcom: add support for QCA807x PHY Family") Signed-off-by: George Moussalem Signed-off-by: Christian Marangi Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20250219130923.7216-1-ansuelsmth@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/phy/qcom/qca807x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/phy/qcom/qca807x.c +++ b/drivers/net/phy/qcom/qca807x.c @@ -774,7 +774,7 @@ static int qca807x_config_init(struct ph control_dac &= ~QCA807X_CONTROL_DAC_MASK; if (!priv->dac_full_amplitude) control_dac |= QCA807X_CONTROL_DAC_DSP_AMPLITUDE; - if (!priv->dac_full_amplitude) + if (!priv->dac_full_bias_current) control_dac |= QCA807X_CONTROL_DAC_DSP_BIAS_CURRENT; if (!priv->dac_disable_bias_current_tweak) control_dac |= QCA807X_CONTROL_DAC_BIAS_CURRENT_TWEAK;