Re: [PATCH stable v5.4 v2 2/3] overflow: Correct check_shl_overflow() comment

[Sasha Levin <sashal@kernel.org>]

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: 4578be130a6470d85ff05b13b75a00e6224eeeeb

WARNING: Author mismatch between patch and upstream commit:
Backport author: Florian Fainelli<florian.fainelli@broadcom.com>
Commit author: Keith Busch<kbusch@kernel.org>

Status in newer kernel trees:
6.13.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (exact SHA1)
6.1.y | Present (exact SHA1)

Note: The patch differs from the upstream commit:
---
1:  4578be130a647 ! 1:  a99708e5c1aad overflow: Correct check_shl_overflow() comment
    @@ Metadata
      ## Commit message ##
         overflow: Correct check_shl_overflow() comment
     
    +    commit 4578be130a6470d85ff05b13b75a00e6224eeeeb upstream
    +
         A 'false' return means the value was safely set, so the comment should
         say 'true' for when it is not considered safe.
     
    @@ Commit message
         Signed-off-by: Kees Cook <keescook@chromium.org>
         Fixes: 0c66847793d1 ("overflow.h: Add arithmetic shift helper")
         Link: https://lore.kernel.org/r/20210401160629.1941787-1-kbusch@kernel.org
    +    Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
     
      ## include/linux/overflow.h ##
     @@ include/linux/overflow.h: static inline bool __must_check __must_check_overflow(bool overflow)
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.4.y        |  Success    |  Success   |