From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F456233D89; Mon, 10 Mar 2025 18:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741630488; cv=none; b=UZkZWjEvIVrKhywsGOhJJ5wEbtx3ksHbLXI+bQ8s3R+mOeuqaQQvYfnLv4QjQe2FHkckrUnjePxtvSBLgTPUBm+sDJAE5PDLlHe9HTOkGt7bQOK0aux+z2gWqW9P8UWdKtshO/Vh7xWEtJVubPR5sUS1wukQ8XQcwnuHWB+oqSI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741630488; c=relaxed/simple; bh=oxox2jv9ISOPeA26ccutausva/NjzYgoEL0BW8NlCdk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CjfoigG5tE68XQNo/atlA4ZbjFgME/83Ru0EPBqfifdw2smGxX+PAwI/WLAwP+tLZ6Ivdl/nlqf7jaIVW2FC8HMqfk+DVrI/Nv80QH7M5ZqhT6H6bxdOdJM4nqSri4o0tOwN1r3BoOXWZvoV84vdhEihKEksI8/Mez1VThfRYm4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dhmlOapP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dhmlOapP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 588D0C4CEE5; Mon, 10 Mar 2025 18:14:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741630487; bh=oxox2jv9ISOPeA26ccutausva/NjzYgoEL0BW8NlCdk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dhmlOapPFfYIBhyFtSGwRvrkPSD1m4Wad1erD0z2uV/Kzy/Zz4ryHBnKUvTesncOO ge+GOxozebGnY2HqDp1Buj94LthcOkhiEGkzH2+NwZJSqOr1j/m+oTvwggQsxKUskZ tAgH/l1s4xVzG6S81p7UcDwTYM9XLiI0hBt9a3b4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lei He , Herbert Xu , Sasha Levin Subject: [PATCH 5.15 432/620] crypto: testmgr - Fix wrong test case of RSA Date: Mon, 10 Mar 2025 18:04:38 +0100 Message-ID: <20250310170602.650899275@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310170545.553361750@linuxfoundation.org> References: <20250310170545.553361750@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lei He [ Upstream commit a9887010ed2da3fddaff83ceec80e2b71be8a966 ] According to the BER encoding rules, integer value should be encoded as two's complement, and if the highest bit of a positive integer is 1, should add a leading zero-octet. The kernel's built-in RSA algorithm cannot recognize negative numbers when parsing keys, so it can pass this test case. Export the key to file and run the following command to verify the fix result: openssl asn1parse -inform DER -in /path/to/key/file Signed-off-by: Lei He Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- crypto/testmgr.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/testmgr.h b/crypto/testmgr.h index d94d02cb30d4e..c2bad3ee89085 100644 --- a/crypto/testmgr.h +++ b/crypto/testmgr.h @@ -257,9 +257,9 @@ static const struct akcipher_testvec rsa_tv_template[] = { }, { #endif .key = - "\x30\x82\x02\x1F" /* sequence of 543 bytes */ + "\x30\x82\x02\x20" /* sequence of 544 bytes */ "\x02\x01\x01" /* version - integer of 1 byte */ - "\x02\x82\x01\x00" /* modulus - integer of 256 bytes */ + "\x02\x82\x01\x01\x00" /* modulus - integer of 256 bytes */ "\xDB\x10\x1A\xC2\xA3\xF1\xDC\xFF\x13\x6B\xED\x44\xDF\xF0\x02\x6D" "\x13\xC7\x88\xDA\x70\x6B\x54\xF1\xE8\x27\xDC\xC3\x0F\x99\x6A\xFA" "\xC6\x67\xFF\x1D\x1E\x3C\x1D\xC1\xB5\x5F\x6C\xC0\xB2\x07\x3A\x6D" @@ -299,7 +299,7 @@ static const struct akcipher_testvec rsa_tv_template[] = { "\x02\x01\x00" /* exponent1 - integer of 1 byte */ "\x02\x01\x00" /* exponent2 - integer of 1 byte */ "\x02\x01\x00", /* coefficient - integer of 1 byte */ - .key_len = 547, + .key_len = 548, .m = "\x54\x85\x9b\x34\x2c\x49\xea\x2a", .c = "\xb2\x97\x76\xb4\xae\x3e\x38\x3c\x7e\x64\x1f\xcc\xa2\x7f\xf6\xbe" -- 2.39.5