From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90CD21C57B2; Mon, 10 Mar 2025 18:19:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741630769; cv=none; b=IOG+QSfuErCje8TeldU/IuLhNCLTASYWAx5kV4fxobzMCth0yydOMA/BmgxcfhdSb6rITV9DO4KWc71TxDGDQm94rSgONjYo3+fI9QJ3jMFZMA5Ixc2VhvLGwzb31ZrTpP8BUs61r9OOl6mT50S7KvwrlZaTTA1ygKEFUsKgXB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741630769; c=relaxed/simple; bh=M7NE7RQBxgl688kH8JYf5JapIXOjcmbaja9hIvsK1O0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HVL95Yuegvi9KZSZp1dlhzsc8zk9Qy5ZZ2JM219M+Z6Dvj8lK/40zYDPehMyuH6OqbXNRr603UIXrdmG08B2ANQRvzentz1QSdAXTpsrkZS44/96Hj6A5PxZe9vU4fanotYEZGxTjLpTdhgtmxRIp/4KiNBrrTXsnTmAwx0anYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aXrtmtCx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aXrtmtCx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17811C4CEE5; Mon, 10 Mar 2025 18:19:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741630769; bh=M7NE7RQBxgl688kH8JYf5JapIXOjcmbaja9hIvsK1O0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aXrtmtCx5ruo6OhvZjzGcIEKa+ZeaGEoEfk/VhQ7XjetNhHob/GJCnxHhWAaHelia xCsI6fNJrfmh1lFC2dbRtgxuV3LXZmxQzf8kxgETsNfYK46SlmobqsD9wdr2P0oPHD KSPUUJviEswlxP63nVgljBq4fL0OGwue+FZQjwXk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mark Zhang , Maher Sanalla , Leon Romanovsky , Sasha Levin Subject: [PATCH 5.15 486/620] IB/mlx5: Set and get correct qp_num for a DCT QP Date: Mon, 10 Mar 2025 18:05:32 +0100 Message-ID: <20250310170604.755187676@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310170545.553361750@linuxfoundation.org> References: <20250310170545.553361750@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mark Zhang [ Upstream commit 12d044770e12c4205fa69535b4fa8a9981fea98f ] When a DCT QP is created on an active lag, it's dctc.port is assigned in a round-robin way, which is from 1 to dev->lag_port. In this case when querying this QP, we may get qp_attr.port_num > 2. Fix this by setting qp->port when modifying a DCT QP, and read port_num from qp->port instead of dctc.port when querying it. Fixes: 7c4b1ab9f167 ("IB/mlx5: Add DCT RoCE LAG support") Signed-off-by: Mark Zhang Reviewed-by: Maher Sanalla Link: https://patch.msgid.link/94c76bf0adbea997f87ffa27674e0a7118ad92a9.1737290358.git.leon@kernel.org Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/mlx5/qp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index d2b4db783b254..d58ed4a09cd93 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -4461,6 +4461,8 @@ static int mlx5_ib_modify_dct(struct ib_qp *ibqp, struct ib_qp_attr *attr, set_id = mlx5_ib_get_counters_id(dev, attr->port_num - 1); MLX5_SET(dctc, dctc, counter_set_id, set_id); + + qp->port = attr->port_num; } else if (cur_state == IB_QPS_INIT && new_state == IB_QPS_RTR) { struct mlx5_ib_modify_qp_resp resp = {}; u32 out[MLX5_ST_SZ_DW(create_dct_out)] = {}; @@ -4949,7 +4951,7 @@ static int mlx5_ib_dct_query_qp(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *mqp, } if (qp_attr_mask & IB_QP_PORT) - qp_attr->port_num = MLX5_GET(dctc, dctc, port); + qp_attr->port_num = mqp->port; if (qp_attr_mask & IB_QP_MIN_RNR_TIMER) qp_attr->min_rnr_timer = MLX5_GET(dctc, dctc, min_rnr_nak); if (qp_attr_mask & IB_QP_AV) { -- 2.39.5