From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63E24230D0F; Mon, 10 Mar 2025 18:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741630910; cv=none; b=CVjlHXY78F/cD23/OvJ0m78fmz47xWkq+RtiZZl9Tjf9R0ZCUpx/roGhww+WthzI7V4QV7haX8cWCC2P7Rm+xPq/wSnWzAGIl4+ARbVA8iaaA9lx7OHPK977wZBDm8Vcn3z8RsZxNpPDU+xqWzvHrMZj8K9V0qQeLaeOu2jFIA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741630910; c=relaxed/simple; bh=jgbJaEiSvZtSYslhXpaoDY2pKWYRSn+0LWzPForfsFM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kei0rWCG6Pe0haM5l7QLd2c2T4SuMEqBbf7EasBPMrLN5s2RTBWxelCuNl1T1gNqFsMPLuhQkbyT2BabIAfqtb9zzghUeBJGlv3C8rgIAAbW1DaO7f5bH28bJegfGrEHQ8VLvz9Yi7xuFLliZsD+AS4/nSrXt79/pWPm++gasHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rVb6kROd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rVb6kROd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60FA6C4CEE5; Mon, 10 Mar 2025 18:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741630909; bh=jgbJaEiSvZtSYslhXpaoDY2pKWYRSn+0LWzPForfsFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rVb6kROdk9hHNwCL++a4FeIdbO5V0v2CIeP6+yGGnnVYdFJrilLls0FHLoOxTG8sD R/Et5ifTdNA6aMLHORTwPEvyW+1KlbHV3A2+LTm7gzkpi0xUsFLWMMMD6XkoQrZA9Y mLq9sntRiYymO3PQEgRwjNn25GvMLXGpZ2aOnAP4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zecheng Li , "Peter Zijlstra (Intel)" , Vincent Guittot , Sasha Levin , K Prateek Nayak Subject: [PATCH 5.15 576/620] sched/fair: Fix potential memory corruption in child_cfs_rq_on_list Date: Mon, 10 Mar 2025 18:07:02 +0100 Message-ID: <20250310170608.277214996@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310170545.553361750@linuxfoundation.org> References: <20250310170545.553361750@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zecheng Li [ Upstream commit 3b4035ddbfc8e4521f85569998a7569668cccf51 ] child_cfs_rq_on_list attempts to convert a 'prev' pointer to a cfs_rq. This 'prev' pointer can originate from struct rq's leaf_cfs_rq_list, making the conversion invalid and potentially leading to memory corruption. Depending on the relative positions of leaf_cfs_rq_list and the task group (tg) pointer within the struct, this can cause a memory fault or access garbage data. The issue arises in list_add_leaf_cfs_rq, where both cfs_rq->leaf_cfs_rq_list and rq->leaf_cfs_rq_list are added to the same leaf list. Also, rq->tmp_alone_branch can be set to rq->leaf_cfs_rq_list. This adds a check `if (prev == &rq->leaf_cfs_rq_list)` after the main conditional in child_cfs_rq_on_list. This ensures that the container_of operation will convert a correct cfs_rq struct. This check is sufficient because only cfs_rqs on the same CPU are added to the list, so verifying the 'prev' pointer against the current rq's list head is enough. Fixes a potential memory corruption issue that due to current struct layout might not be manifesting as a crash but could lead to unpredictable behavior when the layout changes. Fixes: fdaba61ef8a2 ("sched/fair: Ensure that the CFS parent is added after unthrottling") Signed-off-by: Zecheng Li Reviewed-and-tested-by: K Prateek Nayak Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Vincent Guittot Link: https://lore.kernel.org/r/20250304214031.2882646-1-zecheng@google.com Signed-off-by: Sasha Levin --- kernel/sched/fair.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 20044e7506ae1..ea707ee9ddac1 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3303,15 +3303,17 @@ static inline bool child_cfs_rq_on_list(struct cfs_rq *cfs_rq) { struct cfs_rq *prev_cfs_rq; struct list_head *prev; + struct rq *rq = rq_of(cfs_rq); if (cfs_rq->on_list) { prev = cfs_rq->leaf_cfs_rq_list.prev; } else { - struct rq *rq = rq_of(cfs_rq); - prev = rq->tmp_alone_branch; } + if (prev == &rq->leaf_cfs_rq_list) + return false; + prev_cfs_rq = container_of(prev, struct cfs_rq, leaf_cfs_rq_list); return (prev_cfs_rq->tg->parent == cfs_rq->tg); -- 2.39.5