From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D1BC25E805; Tue, 11 Mar 2025 15:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705408; cv=none; b=NnIMTLQccmZI4A5vAGwon66g4K+GbUxYjKkVC0br360OqpteQ+QVGZCnllSS8yyWQYxgP9VBF4MuFm7bbrqu9juSXagtRqd78BN6qZDwLGfrQl+/ne8m3FodTWZuZeERcTr4YhonAxBsbvDFIJmMaYcsYXyqjqYIkwO8YLb8khs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705408; c=relaxed/simple; bh=+I1fGV5iNpUsW5Lapb1an4XDk/tKZlGn8tCswLEtrgs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rj6HDBhywd4JWL+GzVBGQBXjIy3Awtz/N83z6+D252KmL7NhmOj52EQ/IlrDtMWvY4pg6muWl/3DzpgVELfTxaGaaCuVZVqVTPeLiF1hdPxh5e/sij/Bifoffs9V95SfgV8jP5Ivkz5qKHwWQfolNNbjgM9ZRnvwu3iFM10yufM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nif4dPd5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nif4dPd5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2929C4CEE9; Tue, 11 Mar 2025 15:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741705408; bh=+I1fGV5iNpUsW5Lapb1an4XDk/tKZlGn8tCswLEtrgs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nif4dPd5+cQ5XjGaxSo+/0RY1ZvzbDu+jFUoJAyh4890KZJVXiSJr005gAOGABMrV /c/y7Kt5tSk7G8JlBXTxvT686Ac+s8zXUPE8oDF4ku13fUEx9/xkJsWGQh/WnucZ/l A+R1km+Qf/byPyD9frlLjuWSUO/qM5VqFGVu0H0c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joe Hattori , Mark Brown , Sasha Levin Subject: [PATCH 5.4 025/328] regulator: of: Implement the unwind path of of_regulator_match() Date: Tue, 11 Mar 2025 15:56:35 +0100 Message-ID: <20250311145715.888594834@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311145714.865727435@linuxfoundation.org> References: <20250311145714.865727435@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joe Hattori [ Upstream commit dddca3b2fc676113c58b04aaefe84bfb958ac83e ] of_regulator_match() does not release the OF node reference in the error path, resulting in an OF node leak. Therefore, call of_node_put() on the obtained nodes before returning the EINVAL error. Since it is possible that some drivers call this function and do not exit on failure, such as s2mps11_pmic_driver, clear the init_data and of_node in the error path. This was reported by an experimental verification tool that I am developing. As I do not have access to actual devices nor the QEMU board configuration to test drivers that call this function, no runtime test was able to be performed. Fixes: 1c8fa58f4750 ("regulator: Add generic DT parsing for regulators") Signed-off-by: Joe Hattori Link: https://patch.msgid.link/20250104080453.2153592-1-joe@pf.is.s.u-tokyo.ac.jp Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/of_regulator.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index 7a0a235e44658..c4b72fa8ad815 100644 --- a/drivers/regulator/of_regulator.c +++ b/drivers/regulator/of_regulator.c @@ -377,7 +377,7 @@ int of_regulator_match(struct device *dev, struct device_node *node, "failed to parse DT for regulator %pOFn\n", child); of_node_put(child); - return -EINVAL; + goto err_put; } match->of_node = of_node_get(child); count++; @@ -386,6 +386,18 @@ int of_regulator_match(struct device *dev, struct device_node *node, } return count; + +err_put: + for (i = 0; i < num_matches; i++) { + struct of_regulator_match *match = &matches[i]; + + match->init_data = NULL; + if (match->of_node) { + of_node_put(match->of_node); + match->of_node = NULL; + } + } + return -EINVAL; } EXPORT_SYMBOL_GPL(of_regulator_match); -- 2.39.5