From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C41425DAEF; Tue, 11 Mar 2025 15:04:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705498; cv=none; b=jbLrW9rxTKpxBlcmppVrs5Jo68Sqkey8WWheYPBvC4s3ZHD5zQI42VKDil8fWGr/GVCTI7zI61kuaIEVKyLEgubgYeEmga5EczxtIBgGgwP1Gb3GSl4bfQzvVQ5+ga4GBVqpPBEz383d3KmHILBkdNG+qGBomE74pfSrBLDhG8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705498; c=relaxed/simple; bh=UlzWTgRwruR8YsllWnOnUFk5Lh9u7m01NKRqbhjmcR0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OCLqT5Xbc3f/c674bVlUQa9/D6Lw1F2uxnXo4a9Ovw36LIXWSF05SQO7wF5+to87JdaMyj/2Yqik6FFZOX76cO49k9XP+NCv1RATkvdJpyCxIhjCDUFInd76HVN2rULT+nXlGThj/ie1Hnw3pz5+EXBKkwAX2x40OH1MUMFn3P0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oUtnBEjO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oUtnBEjO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7423C4CEE9; Tue, 11 Mar 2025 15:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741705498; bh=UlzWTgRwruR8YsllWnOnUFk5Lh9u7m01NKRqbhjmcR0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oUtnBEjOueJpxBhu6Fl6Yo99NTS9jhu6vroAXCe1qZfLLZqiE5Dadp1zxNzJ01xE/ bAyJkqiex+oOhV5ZiAq/PlvnQl6zKsljVpMqFDybw7v1n9Xu7VuATwXvJ1a/OvfMt8 GsreH/E1NeB/tVISXvd6ffIW9kLbpD7yeYRYK4XI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Namhyung Kim , Adrian Hunter , Ian Rogers , Christophe Leroy , James Clark , Jiri Olsa , Kan Liang , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 5.4 039/328] perf top: Dont complain about lack of vmlinux when not resolving some kernel samples Date: Tue, 11 Mar 2025 15:56:49 +0100 Message-ID: <20250311145716.447891144@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311145714.865727435@linuxfoundation.org> References: <20250311145714.865727435@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnaldo Carvalho de Melo [ Upstream commit 058b38ccd2af9e5c95590b018e8425fa148d7aca ] Recently we got a case where a kernel sample wasn't being resolved due to a bug that was not setting the end address on kernel functions implemented in assembly (see Link: tag), and then those were not being found by machine__resolve() -> map__find_symbol(). So we ended up with: # perf top --stdio PerfTop: 0 irqs/s kernel: 0% exact: 0% lost: 0/0 drop: 0/0 [cycles/P] ----------------------------------------------------------------------- Warning: A vmlinux file was not found. Kernel samples will not be resolved. ^Z [1]+ Stopped perf top --stdio # But then resolving all other kernel symbols. So just fixup the logic to only print that warning when there are no symbols in the kernel map. Fixes: d88205db9caa0e9d ("perf dso: Add dso__has_symbols() method") Reviewed-by: Namhyung Kim Cc: Adrian Hunter Cc: Ian Rogers Cc: Christophe Leroy Cc: James Clark Cc: Jiri Olsa Cc: Kan Liang Link: https://lore.kernel.org/lkml/Z3buKhcCsZi3_aGb@x1 Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/builtin-top.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index b8fab267e8556..5631d44a3f6bc 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -796,7 +796,7 @@ static void perf_event__process_sample(struct perf_tool *tool, * invalid --vmlinux ;-) */ if (!machine->kptr_restrict_warned && !top->vmlinux_warned && - __map__is_kernel(al.map) && map__has_symbols(al.map)) { + __map__is_kernel(al.map) && !map__has_symbols(al.map)) { if (symbol_conf.vmlinux_name) { char serr[256]; dso__strerror_load(al.map->dso, serr, sizeof(serr)); -- 2.39.5