From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F136122CBCC; Tue, 11 Mar 2025 15:04:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705481; cv=none; b=nFt5VjI4co+Szhgr1HzE7BTD/L9kQAOLdjDdTRcpc9nkA/V4bsEoGqnti2l02WAXr4M0ZLNz4n5/tKW5uS7GEPixZYAi+BX2UAbiwAks3W8R7YetiJr6HdamV5ZddLkDj217llTL/zBb3Kso2ixKtzhrgie/0BYZVKldzTIGJzM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705481; c=relaxed/simple; bh=KSeSzmwISY67Gh1DQ9t3bq085XhxoISMDcr0lHf/w2s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qsNs3SkuT5FBjaAR6kyPrxv2NCCn5/B2yMcQh6BIFIYlbFXPJW5WSevoGAPxNai3yP+lOIWsAu5xd/zz90aJoK8w/R7gcBE5eP/O6GTlR5N/vzq7m7wxkANL1y4hPpMILtOXv8YqVjMbQlMAke3fSINx+HG+gZ04x3aTOE5Rov4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nFOTWP7i; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nFOTWP7i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A937C4CEE9; Tue, 11 Mar 2025 15:04:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741705480; bh=KSeSzmwISY67Gh1DQ9t3bq085XhxoISMDcr0lHf/w2s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nFOTWP7iZ+EwOjD0CpSqM5bzFngSyIV9QaUMn392Ea1z84RSFuq8YbD3vybOAK2xd ZpQVP1PQwxDpffZgOOvC1+fi798ivpIGidzFRZpZPrnPrAAXuq0fOwt5xF4Uyyc8MS VGT/I1eQazPfBARWIaqQA4V2jY0KdX7h703kyVzQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chen Ni , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.4 050/328] media: lmedm04: Handle errors for lme2510_int_read Date: Tue, 11 Mar 2025 15:57:00 +0100 Message-ID: <20250311145716.884076742@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311145714.865727435@linuxfoundation.org> References: <20250311145714.865727435@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chen Ni [ Upstream commit a2836d3fe220220ff8c495ca9722f89cea8a67e7 ] Add check for the return value of usb_pipe_endpoint() and usb_submit_urb() in order to catch the errors. Fixes: 15e1ce33182d ("[media] lmedm04: Fix usb_submit_urb BOGUS urb xfer, pipe 1 != type 3 in interrupt urb") Signed-off-by: Chen Ni Link: https://lore.kernel.org/r/20240521091042.1769684-1-nichen@iscas.ac.cn Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2/lmedm04.c index 2b3b780782a40..8c573c3a83d5e 100644 --- a/drivers/media/usb/dvb-usb-v2/lmedm04.c +++ b/drivers/media/usb/dvb-usb-v2/lmedm04.c @@ -372,6 +372,7 @@ static int lme2510_int_read(struct dvb_usb_adapter *adap) struct dvb_usb_device *d = adap_to_d(adap); struct lme2510_state *lme_int = adap_to_priv(adap); struct usb_host_endpoint *ep; + int ret; lme_int->lme_urb = usb_alloc_urb(0, GFP_KERNEL); @@ -389,11 +390,20 @@ static int lme2510_int_read(struct dvb_usb_adapter *adap) /* Quirk of pipe reporting PIPE_BULK but behaves as interrupt */ ep = usb_pipe_endpoint(d->udev, lme_int->lme_urb->pipe); + if (!ep) { + usb_free_urb(lme_int->lme_urb); + return -ENODEV; + } if (usb_endpoint_type(&ep->desc) == USB_ENDPOINT_XFER_BULK) lme_int->lme_urb->pipe = usb_rcvbulkpipe(d->udev, 0xa); - usb_submit_urb(lme_int->lme_urb, GFP_KERNEL); + ret = usb_submit_urb(lme_int->lme_urb, GFP_KERNEL); + if (ret) { + usb_free_urb(lme_int->lme_urb); + return ret; + } + info("INT Interrupt Service Started"); return 0; -- 2.39.5