From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A101425EFB2; Tue, 11 Mar 2025 15:06:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705576; cv=none; b=Ks9EBoyIqWIkgVa+WJVb4DZMRT2BQPhgdYfb/p2HYKDC3FaxMDL/sJW1R3My4vwbzAIooJwoLiKu0kyEP4XEkmo8DFRfJVWtEMBSQcHE00XkGUNQntBiPKzISpnBZylBm7RdI5j7gd+nYbBWKg15yKosIBgBb+S6JWp6XgzKW7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705576; c=relaxed/simple; bh=v0O7dDS8UJVRhfkD7298ncnDXTU0KWQAQ0kaDyJ9sdA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LCa+nSu2UUZHiFR5x86GVFu4lgoiQGj2xMVpGa8lxeXDU+1wz1MwTV3GIgprLFuCShUIdJDg5RtrwFR6fEnf4MkTT+6RYkN1lOJDxfuWq3+BMrGdu/NvS8SZYQUmAg1W6f+C0ZrC9mJgE/BwB882F7sjmsecEY9oZCR6AewAzXM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tr+/u/Ec; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tr+/u/Ec" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0651C4CEEF; Tue, 11 Mar 2025 15:06:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741705576; bh=v0O7dDS8UJVRhfkD7298ncnDXTU0KWQAQ0kaDyJ9sdA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tr+/u/Ecf0M4C37e8e/gbRfuEiOBZWL8X34udLc0P2uUC1UJjx78sNXpmVX0oPtVy T4XFRzMaJG8EtZjFslP04Dl3YNtLd1ViMopCHvVirQrRbzqj6dctdQJdL8RVcZJ5aM gaEOSkeCWPHrcTF0ow2MEWnyq38MiuMy8oMWGw4o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jiasheng Jiang , Krzysztof Kozlowski , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.4 053/328] media: camif-core: Add check for clk_enable() Date: Tue, 11 Mar 2025 15:57:03 +0100 Message-ID: <20250311145717.003397902@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311145714.865727435@linuxfoundation.org> References: <20250311145714.865727435@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiasheng Jiang [ Upstream commit 77ed2470ac09c2b0a33cf3f98cc51d18ba9ed976 ] Add check for the return value of clk_enable() to gurantee the success. Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface") Signed-off-by: Jiasheng Jiang Reviewed-by: Krzysztof Kozlowski Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/s3c-camif/camif-core.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/s3c-camif/camif-core.c index ee624804862e2..3c8c262e3c687 100644 --- a/drivers/media/platform/s3c-camif/camif-core.c +++ b/drivers/media/platform/s3c-camif/camif-core.c @@ -529,10 +529,19 @@ static int s3c_camif_remove(struct platform_device *pdev) static int s3c_camif_runtime_resume(struct device *dev) { struct camif_dev *camif = dev_get_drvdata(dev); + int ret; + + ret = clk_enable(camif->clock[CLK_GATE]); + if (ret) + return ret; - clk_enable(camif->clock[CLK_GATE]); /* null op on s3c244x */ - clk_enable(camif->clock[CLK_CAM]); + ret = clk_enable(camif->clock[CLK_CAM]); + if (ret) { + clk_disable(camif->clock[CLK_GATE]); + return ret; + } + return 0; } -- 2.39.5