From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0371925DD00; Tue, 11 Mar 2025 15:05:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705556; cv=none; b=tCKwTNwnGnjJ36vdKYn9eCk3H3zkL1C6tADa6OyL3ay4pLD5BpyjZlFhIZE1v08UR3FIJx9seuswxBbyNfwBc9QcUbeDycuUrjwlGZGJfqt/D349+PAvxWeBdmZIfxYbXYHJLkwHTf6byw4DPWkS8ufW0TeTI7lh7/8a1EgkKPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705556; c=relaxed/simple; bh=MrMrOjzd7csFCASmd5fi7rtCYh3BBeNU1gtGvtJ09oI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ttah2y75NC9wSXFDUOPYzWUWfic95buJldQo9e7379iVMgS16MPRAtgWmWGE0MlIoC3nc2s6Eb6HKh8HsMGDD+72jMQ3uASAB19GQPDj9IcYHoMeVWNncWEvj9BmwWlqQTwTzwecvKZmlwSHw5qJ2XtDvQYnB19x/2pfxHly90s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EhCpcpsz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EhCpcpsz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B865C4CEE9; Tue, 11 Mar 2025 15:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741705555; bh=MrMrOjzd7csFCASmd5fi7rtCYh3BBeNU1gtGvtJ09oI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EhCpcpszejFjk1oaq4yrbzOaNLeWGouly1ETABUBFkfsEA2rI2iWrqzrMVzhFEf31 DqVZ5VbqxIShQGzqaJtwwWXlm6uVjrHfldFYAoljs5MZpTCxIRkpaAXSe7ikXIVQV0 FPSDtI3JCUY1rF35WOq9h0Rq9Vuu5w/IFfyqtY6Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sreekanth Reddy , Paul Menzel , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 056/328] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1 Date: Tue, 11 Mar 2025 15:57:06 +0100 Message-ID: <20250311145717.124157751@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311145714.865727435@linuxfoundation.org> References: <20250311145714.865727435@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Paul Menzel [ Upstream commit ad7c3c0cb8f61d6d5a48b83e62ca4a9fd2f26153 ] Currently, the code does: if (x == 0) { x &= ~0x3; x |= 0x1; } Zeroing bits 0 and 1 of a variable that is 0 is not necessary. So directly set the variable to 1. Cc: Sreekanth Reddy Fixes: f92363d12359 ("[SCSI] mpt3sas: add new driver supporting 12GB SAS") Signed-off-by: Paul Menzel Link: https://lore.kernel.org/r/20241212221817.78940-2-pmenzel@molgen.mpg.de Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 69023ddceb59f..7df4e8cfeb923 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -4627,8 +4627,7 @@ _base_static_config_pages(struct MPT3SAS_ADAPTER *ioc) if (!ioc->is_gen35_ioc && ioc->manu_pg11.EEDPTagMode == 0) { pr_err("%s: overriding NVDATA EEDPTagMode setting\n", ioc->name); - ioc->manu_pg11.EEDPTagMode &= ~0x3; - ioc->manu_pg11.EEDPTagMode |= 0x1; + ioc->manu_pg11.EEDPTagMode = 0x1; mpt3sas_config_set_manufacturing_pg11(ioc, &mpi_reply, &ioc->manu_pg11); } -- 2.39.5