From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EB2F25DB0B; Tue, 11 Mar 2025 15:08:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705703; cv=none; b=pQozpAM/crYvrhVQqUaVrqYTgkM7rloa8k5w/5wSrS+C0karbJ9Bh0gFgE8sFPVZ2wwglaz1qwPsYWopk/fosFOCeLgV472wMUXyRJmeXYUAn6UxrWcooJs8NuV5CcLEi24Ib4DLWY2Iekwg4/olDjZvwteYsmozzUQd8SksesY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705703; c=relaxed/simple; bh=CfkrHfSPi6rCcw4xXlo5kId5rgjpc/CMshDtMKpeFFQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fPWedLvVndTRH8pNQU3slfT9HETntooKNNCV9sZtoroU0SNz5mppIVuBLIbd58WGqXImPlctbnQU1CRYd3uJnw+bbJiaEp8SnQHKZnxtg8saAIbYpghn/1HSFwEXnb11zTifcmWedCzR8D6B63XvQ0pfHIE7SsN51RCf+OX2z6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bhJ9zDMO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bhJ9zDMO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E75FC4CEE9; Tue, 11 Mar 2025 15:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741705702; bh=CfkrHfSPi6rCcw4xXlo5kId5rgjpc/CMshDtMKpeFFQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bhJ9zDMOOazsYQMO+usj5dB9Y6bsryoUsbvGo8C7GcLqk4Ze5hOW3BtgyE9o7TZCs drX0r/bRZspF6flWDNv/9vjXINiUWg+1t92N6OySG622B8kEg0alkQV4X5juU+kDiU k/+Sr/0nzAUyyhyK27OJ9YiOXdjU34JDBkidbp80= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ralf Schlatterbeck , Mark Brown , Stefan Wahren Subject: [PATCH 5.4 096/328] spi-mxs: Fix chipselect glitch Date: Tue, 11 Mar 2025 15:57:46 +0100 Message-ID: <20250311145718.708339936@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311145714.865727435@linuxfoundation.org> References: <20250311145714.865727435@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ralf Schlatterbeck commit 269e31aecdd0b70f53a05def79480f15cbcc0fd6 upstream. There was a change in the mxs-dma engine that uses a new custom flag. The change was not applied to the mxs spi driver. This results in chipselect being deasserted too early. This fixes the chipselect problem by using the new flag in the mxs-spi driver. Fixes: ceeeb99cd821 ("dmaengine: mxs: rename custom flag") Signed-off-by: Ralf Schlatterbeck Link: https://msgid.link/r/20240202115330.wxkbfmvd76sy3a6a@runtux.com Signed-off-by: Mark Brown Cc: Stefan Wahren Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-mxs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/spi/spi-mxs.c +++ b/drivers/spi/spi-mxs.c @@ -40,6 +40,7 @@ #include #include #include +#include #define DRIVER_NAME "mxs-spi" @@ -253,7 +254,7 @@ static int mxs_spi_txrx_dma(struct mxs_s desc = dmaengine_prep_slave_sg(ssp->dmach, &dma_xfer[sg_count].sg, 1, (flags & TXRX_WRITE) ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM, - DMA_PREP_INTERRUPT | DMA_CTRL_ACK); + DMA_PREP_INTERRUPT | MXS_DMA_CTRL_WAIT4END); if (!desc) { dev_err(ssp->dev,