From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36C1425DCE3; Tue, 11 Mar 2025 15:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705775; cv=none; b=FlUDCC+h+EElGxzdk3kZMT52Y3BYgAJzvFkzEV6NBO/tgccBtjcWiVQ3boKJ/BfZbiAnPw2ZWTKQp8v/qM4SIrvx+Phr5JBRXOnw9XBgU6HJtjj8mui8te4UDBZv4xAZiHwEgcbToKkATNX/UpFMPld8r4ojEa0hxy4iJbhhT/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705775; c=relaxed/simple; bh=RLA4NnTRREKV0wBo8a5QcxRmae6wSa6aNLDwSmfg4Q4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gd7fyJpTpC/eBjk5wIpXaxSBHrB9KQS+lca7s1fkH9ZXatC8K/0pQZkUSURFgirEwYqvuFVpCAQIlrGhz+NRPnJaiiy6As7NfWCorbSJ/eAFmjzPdXLx/IF6rwJ5QmOKzR/KnjBrldCwRL8+gaTX6UYblJ9TjRZygYz1VfSe23I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZAmaIRTs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZAmaIRTs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49C6DC4CEE9; Tue, 11 Mar 2025 15:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741705774; bh=RLA4NnTRREKV0wBo8a5QcxRmae6wSa6aNLDwSmfg4Q4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZAmaIRTsEYoyViJb8rn5Oo2hbvx1SUgTF8zM2AlaTLVN48IdgL83y9+h3j/gH1WTP fEoIPEOGmPklUwlWl5WumJXBJVJs5q5yPpcHnAb864BAQLYs2Z4PYh5+t1cKCOjrPe Cej94zglO2Y/6rDpHLYut5u32+GaDvly9j28nHjM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mostafa Saleh , Eric Auger , Alex Williamson Subject: [PATCH 5.4 151/328] vfio/platform: check the bounds of read/write syscalls Date: Tue, 11 Mar 2025 15:58:41 +0100 Message-ID: <20250311145720.908253401@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311145714.865727435@linuxfoundation.org> References: <20250311145714.865727435@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alex Williamson commit ce9ff21ea89d191e477a02ad7eabf4f996b80a69 upstream. count and offset are passed from user space and not checked, only offset is capped to 40 bits, which can be used to read/write out of bounds of the device. Fixes: 6e3f26456009 (“vfio/platform: read and write support for the device fd”) Cc: stable@vger.kernel.org Reported-by: Mostafa Saleh Reviewed-by: Eric Auger Reviewed-by: Mostafa Saleh Tested-by: Mostafa Saleh Signed-off-by: Alex Williamson Signed-off-by: Greg Kroah-Hartman --- drivers/vfio/platform/vfio_platform_common.c | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/drivers/vfio/platform/vfio_platform_common.c +++ b/drivers/vfio/platform/vfio_platform_common.c @@ -410,6 +410,11 @@ static ssize_t vfio_platform_read_mmio(s count = min_t(size_t, count, reg->size - off); + if (off >= reg->size) + return -EINVAL; + + count = min_t(size_t, count, reg->size - off); + if (!reg->ioaddr) { reg->ioaddr = ioremap_nocache(reg->addr, reg->size); @@ -489,6 +494,11 @@ static ssize_t vfio_platform_write_mmio( if (off >= reg->size) return -EINVAL; + + count = min_t(size_t, count, reg->size - off); + + if (off >= reg->size) + return -EINVAL; count = min_t(size_t, count, reg->size - off);