From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68EEB249F9; Tue, 11 Mar 2025 15:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705837; cv=none; b=AMqB9xzOnceWxu4DD9nwqt+dog+AhE3K0yL/2b08W6+GGpzj2TIXfiAu7UNc/eVLtpCd+OccIDb6Tbsi/kVVfCv0msjckifZBoLD01kNST8XFLoQyAdk3JHfv+btEQPiOfs0aE5iCQB948YonJDU2+LPELfbvpuX8t7TDrtXaSw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705837; c=relaxed/simple; bh=VqnsLKdxc5JTQQ7t1otDpXTvGSz3sC8OpONVW7rUTcE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=khV9SpE1IoKnwZRzFkmrgQOprBC7zR1gbaYx8Bxpy/H0ktmMePAtcxsv54fHafHNdpNGC/KtRaJwcJLyod8wmz2TZifyRYY7WBQSqlIe/0tty8NKGy0F5NaRn4s2XcQxhwRS8YyRJbEcKgi3cOKeoWjf4pAKlIHMHQp2r28ZWJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=16nEj8Je; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="16nEj8Je" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E822AC4CEE9; Tue, 11 Mar 2025 15:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741705837; bh=VqnsLKdxc5JTQQ7t1otDpXTvGSz3sC8OpONVW7rUTcE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=16nEj8JexSEfr7j5wzrw9bnP+Fn8z4trBuHxyW25iui2bWIAw9QikgSo3Vx7mg61Q sKBMfKJwxhMyP8qGgNh4DsElFX8H+vNir5/+3TiBdp5T64Lcp/ES5j7iM6l0lCgkvm YGHSf6Q2sBTvV/VgJuXkm3dJGvMfMwgeDCEsszhc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Naresh Kamboju , Linux Kernel Functional Testing , Arnd Bergmann , Hans Verkuil , Sasha Levin Subject: [PATCH 5.4 172/328] media: cxd2841er: fix 64-bit division on gcc-9 Date: Tue, 11 Mar 2025 15:59:02 +0100 Message-ID: <20250311145721.744984018@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311145714.865727435@linuxfoundation.org> References: <20250311145714.865727435@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnd Bergmann [ Upstream commit 8d46603eeeb4c6abff1d2e49f2a6ae289dac765e ] It appears that do_div() once more gets confused by a complex expression that ends up not quite being constant despite __builtin_constant_p() thinking it is: ERROR: modpost: "__aeabi_uldivmod" [drivers/media/dvb-frontends/cxd2841er.ko] undefined! Use div_u64() instead, forcing the expression to be evaluated first, and making it a bit more readable. Cc: Dan Carpenter Reported-by: Naresh Kamboju Closes: https://lore.kernel.org/linux-media/CA+G9fYvvNm-aYodLaAwwTjEGtX0YxR-1R14FOA5aHKt0sSVsYg@mail.gmail.com/ Reported-by: Linux Kernel Functional Testing Closes: https://lore.kernel.org/linux-media/CA+G9fYvvNm-aYodLaAwwTjEGtX0YxR-1R14FOA5aHKt0sSVsYg@mail.gmail.com/ Signed-off-by: Arnd Bergmann Signed-off-by: Hans Verkuil [hverkuil: added Closes tags] Signed-off-by: Sasha Levin --- drivers/media/dvb-frontends/cxd2841er.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/dvb-frontends/cxd2841er.c b/drivers/media/dvb-frontends/cxd2841er.c index 6b495fc36fd0c..51e890554457d 100644 --- a/drivers/media/dvb-frontends/cxd2841er.c +++ b/drivers/media/dvb-frontends/cxd2841er.c @@ -310,12 +310,8 @@ static int cxd2841er_set_reg_bits(struct cxd2841er_priv *priv, static u32 cxd2841er_calc_iffreq_xtal(enum cxd2841er_xtal xtal, u32 ifhz) { - u64 tmp; - - tmp = (u64) ifhz * 16777216; - do_div(tmp, ((xtal == SONY_XTAL_24000) ? 48000000 : 41000000)); - - return (u32) tmp; + return div_u64(ifhz * 16777216ull, + (xtal == SONY_XTAL_24000) ? 48000000 : 41000000); } static u32 cxd2841er_calc_iffreq(u32 ifhz) -- 2.39.5