From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0069F1C5D77; Tue, 11 Mar 2025 15:11:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705864; cv=none; b=sceDAcLGaz6ztN3UWe0UtnHptwgXmlJlr5KcXeHvb9ke3w0D+rDyWBF1+j5fltANKeTvfTMo1SXFmhT52SvhH2FZZdXDmLg77uHdaY4Ut2CxlUvngGfHpWjGcrhW0ow/6D/X/cYxtf4JcAYI/TJQSpRIssHBo12BKXnkWsTR48Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741705864; c=relaxed/simple; bh=Mm0rmHrfIwcIQDbdztFSAGqQ8pJ7+30FGge9WigUOnQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XsGNBE68Rk0CA44DM8D8fco39dacbRr3iYRud/CO4ZvLomH372lfevI5cmocSCJYkVNlqcgAtqbbcckNS7odQgbyF2OOAeRCLqfuKIESODkgi1kWzKYCLF5xjdxtUkG7pGznmlPNeBQpcMdCvNLARgZPOmoSOGglUYRkzC+74AM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=H8V0X2AZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="H8V0X2AZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23FC1C4CEE9; Tue, 11 Mar 2025 15:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741705863; bh=Mm0rmHrfIwcIQDbdztFSAGqQ8pJ7+30FGge9WigUOnQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H8V0X2AZA3a5glfeSEM/tmZUrbnNo4Juk/voCTUvBUsYotWDqjuxlP3LDkMOBJiev dal6D4UtP/xXzOF1QxXDJ9RcTyct4rDQx0mDEqTCvtcT9YiPthRX/cKOCt1uaqNusP 5XPJm2CYX4uLf823TtZGF8C987fEigK4+KawBtO4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Fabrice Gasnier Subject: [PATCH 5.4 180/328] usb: dwc2: gadget: remove of_node reference upon udc_stop Date: Tue, 11 Mar 2025 15:59:10 +0100 Message-ID: <20250311145722.057007373@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311145714.865727435@linuxfoundation.org> References: <20250311145714.865727435@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fabrice Gasnier commit 58cd423820d5b5610977e55e4acdd06628829ede upstream. In dwc2_hsotg_udc_start(), e.g. when binding composite driver, "of_node" is set to hsotg->dev->of_node. It causes errors when binding the gadget driver several times, on stm32mp157c-ev1 board. Below error is seen: "pin PA10 already requested by 49000000.usb-otg; cannot claim for gadget.0" The first time, no issue is seen as when registering the driver, of_node isn't NULL: -> gadget_dev_desc_UDC_store -> usb_gadget_register_driver_owner -> driver_register ... -> really_probe -> pinctrl_bind_pins (no effect) Then dwc2_hsotg_udc_start() sets of_node. The second time (stop the gadget, reconfigure it, then start it again), of_node has been set, so the probing code tries to acquire pins for the gadget. These pins are hold by the controller, hence the error. So clear gadget.dev.of_node in udc_stop() routine to avoid the issue. Fixes: 7d7b22928b90 ("usb: gadget: s3c-hsotg: Propagate devicetree to gadget drivers") Cc: stable Signed-off-by: Fabrice Gasnier Link: https://lore.kernel.org/r/20250124173325.2747710-1-fabrice.gasnier@foss.st.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc2/gadget.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -4548,6 +4548,7 @@ static int dwc2_hsotg_udc_stop(struct us spin_lock_irqsave(&hsotg->lock, flags); hsotg->driver = NULL; + hsotg->gadget.dev.of_node = NULL; hsotg->gadget.speed = USB_SPEED_UNKNOWN; hsotg->enabled = 0;