From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4F7525E81B; Tue, 11 Mar 2025 15:19:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741706348; cv=none; b=Pow/hQxLZ3aZ3F6G+ZKaB1dKJ5JHkGoRNezV51/IvYnkMF4jbqPyBGz7dWsOyhet2B27vEoHz13xTBqJxsHTe4x1zpQ0sYenvtdMETroJqOJ9v1kV6BHHKD/qYahTHNEedT3lRd50TcfYd7geGiLdI3gP10mf6nEsr9CHyVtx4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741706348; c=relaxed/simple; bh=pJ44pDbfpJwHbo7InH7ChF30mQqWhBJsyc2Abw+OAkQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HGPM74Dhea/ZhWrf3xZiXe9M7ByBOMqc0yKmyOHOYZitH4SUSpeoSQV6NfKwL+raA1UC8WYsplROjDpD8Mb03nM1XmgESg7xV37MxqQGv4zplk0JIaZxYiC4xuc9Fb2X0YOaBbF6LLrksiPwsg/sK0hC4RKWC/T+RU+5ZwsAdEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SgU04qjp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SgU04qjp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC9CAC4CEE9; Tue, 11 Mar 2025 15:19:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741706348; bh=pJ44pDbfpJwHbo7InH7ChF30mQqWhBJsyc2Abw+OAkQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SgU04qjpdMWVupPMFtYUGfaOmPoBsRm9IdzFlcuf6gcFJT4zFrGUP0d6LsGNO+W8f 73ui4iVpuIG3TiSAI5kw4aYXSJ2FuqPW7jjg8ZE6nYepTFy7o5PrWHFNq/6DEDVUVU PqolCVS2l2eFZKprx+cP2VyQ3KN0ALK+8F7blTL4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mingwei Zheng , Jiasheng Jiang , Mark Brown , Sasha Levin Subject: [PATCH 5.10 018/462] spi: zynq-qspi: Add check for clk_enable() Date: Tue, 11 Mar 2025 15:54:44 +0100 Message-ID: <20250311145759.070348113@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311145758.343076290@linuxfoundation.org> References: <20250311145758.343076290@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mingwei Zheng [ Upstream commit 8332e667099712e05ec87ba2058af394b51ebdc9 ] Add check for the return value of clk_enable() to catch the potential error. Fixes: c618a90dcaf3 ("spi: zynq-qspi: Drop GPIO header") Signed-off-by: Mingwei Zheng Signed-off-by: Jiasheng Jiang Link: https://patch.msgid.link/20241207015206.3689364-1-zmw12306@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-zynq-qspi.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c index 13c0b15fe1764..2be764d5460d3 100644 --- a/drivers/spi/spi-zynq-qspi.c +++ b/drivers/spi/spi-zynq-qspi.c @@ -379,12 +379,21 @@ static int zynq_qspi_setup_op(struct spi_device *spi) { struct spi_controller *ctlr = spi->master; struct zynq_qspi *qspi = spi_controller_get_devdata(ctlr); + int ret; if (ctlr->busy) return -EBUSY; - clk_enable(qspi->refclk); - clk_enable(qspi->pclk); + ret = clk_enable(qspi->refclk); + if (ret) + return ret; + + ret = clk_enable(qspi->pclk); + if (ret) { + clk_disable(qspi->refclk); + return ret; + } + zynq_qspi_write(qspi, ZYNQ_QSPI_ENABLE_OFFSET, ZYNQ_QSPI_ENABLE_ENABLE_MASK); -- 2.39.5