From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AF6B25E822; Tue, 11 Mar 2025 15:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741706617; cv=none; b=CkPblGnOuI1JSBtUcj4bhHJYPoCnsLNyiNMOQeugCJH1kdKFWV5TNMTcfGtmOpcmFoZMIQrhKupD4jsfg62srEKKW0W9pOAZp0hZIj+e5GCNlKuPF2+/zBzNH0PLYAynopKJqED3dtPWgycJre0LjxozZVaJhEfe/qgQoIKNhlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741706617; c=relaxed/simple; bh=1etI2YL3zFt8qXAaXYZpK8pPA+ij9KD8kte+02DvhHk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PjPAd/VwB60xI2bJbKrdIuOos0CXr1CM5ox6OpSsxM783ygHfjD0d1QbH+fTqsRSTZIoBfsKSlebHj5DStMp4UiL4aG80ucdlZEMfUroelQAv2dwQVp++6v+1kVGtIfj2cnanZgqqGjNShYKfyhg0XltFLOow7rQ2Z1cOcCZJSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YLDT9Cst; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YLDT9Cst" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B37AC4CEEA; Tue, 11 Mar 2025 15:23:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741706616; bh=1etI2YL3zFt8qXAaXYZpK8pPA+ij9KD8kte+02DvhHk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YLDT9CstAMi3Qz+kjEewf3NJSbRFNCyKr6PONnuenD+0hb5F5wMzygbrk1ynQb9tU 3YwFqlyIzxAOhfRE03y4gUoIHllXUxvaFUs2gm/ex6WZLOIcrrtWk0ub1mpCqNt9bu q3t8B7BUxB/QqbR97l+dTrH47B1KAgii28x3e8x8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joe Hattori , Laurent Pinchart , Helge Deller , Sasha Levin Subject: [PATCH 5.10 078/462] fbdev: omapfb: Fix an OF node leak in dss_of_port_get_parent_device() Date: Tue, 11 Mar 2025 15:55:44 +0100 Message-ID: <20250311145801.429360784@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311145758.343076290@linuxfoundation.org> References: <20250311145758.343076290@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joe Hattori [ Upstream commit de124b61e179e690277116e6be512e4f422b5dd8 ] dss_of_port_get_parent_device() leaks an OF node reference when i >= 2 and struct device_node *np is present. Since of_get_next_parent() obtains a reference of the returned OF node, call of_node_put() before returning NULL. This was found by an experimental verifier that I am developing, and no runtime test was able to be performed due to that lack of actual devices. Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb") Signed-off-by: Joe Hattori Reviewed-by: Laurent Pinchart Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c b/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c index 0282d4eef139d..3b16c3342cb77 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c @@ -102,6 +102,7 @@ struct device_node *dss_of_port_get_parent_device(struct device_node *port) np = of_get_next_parent(np); } + of_node_put(np); return NULL; } -- 2.39.5