From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DB6425EFB3; Tue, 11 Mar 2025 15:26:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741706771; cv=none; b=WvaRdtWhILDBWtopa8DSxpkITq91HFh1kd6fvAu3oQT556CEL5jwQhr3YY7r9EOqCDn8+6j8PhsrXnRHWjHhIk3JIYk8D2jggFF7LHUcnAd0OIEYR40tD15YqIPeigtzWYNWPsiuBQScEG1gXli3DH0f+/AOb6fC1eP3BYQqMo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741706771; c=relaxed/simple; bh=taoGJtwaakjQJolu7Z16LpjckCJoDq/kTwSCdPLmClw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eSx7+JXosQDcFfaIeZGP8Za9W/PhsLzk8QQaPVtvKziHHSUMiysSA/gBNvggMxPP2DxBCpKEC8DLdzKINJq2+bTa5zKkOltrUbH2IbLJinWUu4EX/DValMTknISnG3mUatfF3HxekOb/4RDoW/qCYG4B7mrEOcuxCh0JMrlQ9OU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=x3NevCnz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="x3NevCnz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71D72C4CEE9; Tue, 11 Mar 2025 15:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741706771; bh=taoGJtwaakjQJolu7Z16LpjckCJoDq/kTwSCdPLmClw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x3NevCnzYg4sBB0D7XVIVc7m/s54p+bpo6YxqsvRJuIAyEiqcPcz9NZK/elIOC9NQ nPfKCQIVqLyF61UC32erlVXIm+tN25TDapRqVv5gwRVuarVPXLU8KMgDq7+yslAhkj dWL7GQCehvrCgL0iFUlhIPbopRYYAc369czYnWLM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Liu Ye , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 144/462] selftests/net/ipsec: Fix Null pointer dereference in rtattr_pack() Date: Tue, 11 Mar 2025 15:56:50 +0100 Message-ID: <20250311145804.044287993@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311145758.343076290@linuxfoundation.org> References: <20250311145758.343076290@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Liu Ye [ Upstream commit 3a0b7fa095212b51ed63892540c4f249991a2d74 ] Address Null pointer dereference / undefined behavior in rtattr_pack (note that size is 0 in the bad case). Flagged by cppcheck as: tools/testing/selftests/net/ipsec.c:230:25: warning: Possible null pointer dereference: payload [nullPointer] memcpy(RTA_DATA(attr), payload, size); ^ tools/testing/selftests/net/ipsec.c:1618:54: note: Calling function 'rtattr_pack', 4th argument 'NULL' value is 0 if (rtattr_pack(&req.nh, sizeof(req), XFRMA_IF_ID, NULL, 0)) { ^ tools/testing/selftests/net/ipsec.c:230:25: note: Null pointer dereference memcpy(RTA_DATA(attr), payload, size); ^ Signed-off-by: Liu Ye Link: https://patch.msgid.link/20250116013037.29470-1-liuye@kylinos.cn Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- tools/testing/selftests/net/ipsec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/ipsec.c b/tools/testing/selftests/net/ipsec.c index 03b048b668315..38f0de299605a 100644 --- a/tools/testing/selftests/net/ipsec.c +++ b/tools/testing/selftests/net/ipsec.c @@ -189,7 +189,8 @@ static int rtattr_pack(struct nlmsghdr *nh, size_t req_sz, attr->rta_len = RTA_LENGTH(size); attr->rta_type = rta_type; - memcpy(RTA_DATA(attr), payload, size); + if (payload) + memcpy(RTA_DATA(attr), payload, size); return 0; } -- 2.39.5