From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Magali Lemes <magali.lemes@canonical.com>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.4 4/4] sctp: sysctl: auth_enable: avoid using current->nsproxy
Date: Thu, 13 Mar 2025 05:08:41 -0400 [thread overview]
Message-ID: <20250312235036-ab62536f582e2005@stable.kernel.org> (raw)
In-Reply-To: <20250311185427.1070104-5-magali.lemes@canonical.com>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: 15649fd5415eda664ef35780c2013adeb5d9c695
WARNING: Author mismatch between patch and upstream commit:
Backport author: Magali Lemes<magali.lemes@canonical.com>
Commit author: Matthieu Baerts (NGI0)<matttbe@kernel.org>
Status in newer kernel trees:
6.13.y | Present (exact SHA1)
6.12.y | Present (different SHA1: c184bc621e3c)
6.6.y | Present (different SHA1: 7ec30c54f339)
6.1.y | Present (different SHA1: 1b67030d39f2)
5.15.y | Present (different SHA1: bd2a29394235)
5.10.y | Present (different SHA1: dc583e7e5f85)
Note: The patch differs from the upstream commit:
---
1: 15649fd5415ed ! 1: 43321e75147b6 sctp: sysctl: auth_enable: avoid using current->nsproxy
@@ Metadata
## Commit message ##
sctp: sysctl: auth_enable: avoid using current->nsproxy
+ commit 15649fd5415eda664ef35780c2013adeb5d9c695 upstream.
+
As mentioned in a previous commit of this series, using the 'net'
structure via 'current' is not recommended for different reasons:
@@ Commit message
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250108-net-sysctl-current-nsproxy-v1-6-5df34b2083e8@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+ Signed-off-by: Magali Lemes <magali.lemes@canonical.com>
## net/sctp/sysctl.c ##
-@@ net/sctp/sysctl.c: static int proc_sctp_do_alpha_beta(const struct ctl_table *ctl, int write,
- static int proc_sctp_do_auth(const struct ctl_table *ctl, int write,
- void *buffer, size_t *lenp, loff_t *ppos)
+@@ net/sctp/sysctl.c: static int proc_sctp_do_auth(struct ctl_table *ctl, int write,
+ void __user *buffer, size_t *lenp,
+ loff_t *ppos)
{
- struct net *net = current->nsproxy->net_ns;
+ struct net *net = container_of(ctl->data, struct net, sctp.auth_enable);
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.4.y | Success | Success |
prev parent reply other threads:[~2025-03-13 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 18:54 [PATCH 5.4 0/4] sctp: sysctl: fix argument passed to container_of Magali Lemes
2025-03-11 18:54 ` [PATCH 5.4 1/4] Revert "sctp: sysctl: cookie_hmac_alg: avoid using current->nsproxy" Magali Lemes
2025-03-13 9:01 ` Sasha Levin
2025-03-11 18:54 ` [PATCH 5.4 2/4] Revert "sctp: sysctl: auth_enable: " Magali Lemes
2025-03-13 9:01 ` Sasha Levin
2025-03-11 18:54 ` [PATCH 5.4 3/4] sctp: sysctl: cookie_hmac_alg: avoid using current->nsproxy Magali Lemes
2025-03-13 9:08 ` Sasha Levin
2025-03-11 18:54 ` [PATCH 5.4 4/4] sctp: sysctl: auth_enable: " Magali Lemes
2025-03-13 9:08 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312235036-ab62536f582e2005@stable.kernel.org \
--to=sashal@kernel.org \
--cc=magali.lemes@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox