From: Greg KH <gregkh@linuxfoundation.org>
To: Zenm Chen <zenmchen@gmail.com>
Cc: stable@vger.kernel.org, pkshih@realtek.com
Subject: Re: [PATCH 6.6.y 1/2] wifi: rtw89: pci: add pre_deinit to be called after probe complete
Date: Thu, 13 Mar 2025 17:08:03 +0100 [thread overview]
Message-ID: <2025031300-ablaze-snazzy-8996@gregkh> (raw)
In-Reply-To: <20250311081001.1394-2-zenmchen@gmail.com>
On Tue, Mar 11, 2025 at 04:10:00PM +0800, Zenm Chen wrote:
> From: Ping-Ke Shih <pkshih@realtek.com>
>
> [ Upstream commit 9e1aff437a560cd72cb6a60ee33fe162b0afdaf1 ]
>
> At probe stage, we only do partial initialization to enable ability to
> download firmware and read capabilities. After that, we use this pre_deinit
> to disable HCI to save power.
>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> Signed-off-by: Kalle Valo <kvalo@kernel.org>
> Link: https://lore.kernel.org/r/20231110012319.12727-4-pkshih@realtek.com
> [ Zenm: minor fix to make it apply on 6.6.y ]
That was not "minor" changes, as your diff looks like:
> Signed-off-by: Zenm Chen <zenmchen@gmail.com>
> ---
> drivers/net/wireless/realtek/rtw89/core.c | 2 ++
> drivers/net/wireless/realtek/rtw89/core.h | 6 ++++++
> drivers/net/wireless/realtek/rtw89/pci.c | 8 ++++++++
> 3 files changed, 16 insertions(+)
But the original was:
drivers/net/wireless/realtek/rtw89/core.c | 2 ++
drivers/net/wireless/realtek/rtw89/core.h | 6 ++++++
drivers/net/wireless/realtek/rtw89/pci.c | 2 ++
drivers/net/wireless/realtek/rtw89/pci.h | 12 ++++++++++++
drivers/net/wireless/realtek/rtw89/pci_be.c | 18 ++++++++++++++++++
drivers/net/wireless/realtek/rtw89/reg.h | 9 +++++++++
6 files changed, 49 insertions(+)
That is a big difference.
Please either backport the whole thing, or document exactly what you
changed here. Otherwise this looks like a totally new patch and we
can't take that for obvious reasons.
thanks,
greg k-h
next prev parent reply other threads:[~2025-03-13 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 8:09 [PATCH 6.6.y 0/2] wifi: rtw89: RTL8852BE: Fix the shutdown issue Zenm Chen
2025-03-11 8:10 ` [PATCH 6.6.y 1/2] wifi: rtw89: pci: add pre_deinit to be called after probe complete Zenm Chen
2025-03-13 9:01 ` Sasha Levin
2025-03-13 16:08 ` Greg KH [this message]
2025-03-13 20:38 ` [PATCH 6.6.y 1/2] wifi: rtw89: pci: add pre_deinit to be called Zenm Chen
2025-03-11 8:10 ` [PATCH 6.6.y 2/2] wifi: rtw89: pci: disable PCIE wake bit when PCIE deinit Zenm Chen
2025-03-13 9:01 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025031300-ablaze-snazzy-8996@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=pkshih@realtek.com \
--cc=stable@vger.kernel.org \
--cc=zenmchen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox