From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5F3515A843 for ; Fri, 14 Mar 2025 07:49:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741938592; cv=none; b=GxytQYuTmEcwQIXWEZYmDxRMJ9iJdOKUipbuGDH6993N3TdMCFYd5TVYbXPsC6zswDjT1woVxp9Ce/QygwBPPfSt22pitvbTSu3Z5KqIe0qJCHvZoxbsa9HbN7Pq7NiwchbEBe1Raf4xeU/h30shxfSm/otQo4XtL8lffFQ6QVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741938592; c=relaxed/simple; bh=F2CKtsqXWruFpKjUFngj7uienFU84ae/LFc7ulNmznc=; h=Subject:To:From:Date:Message-ID:MIME-Version:Content-Type; b=dYV87Ba4fVjiDXv18zpsRnjC1FlzzZIzGuSKarwTCMFyhOcwXAmK5JABPeqRAAwwPI2lGL0l8wJXGkkhmZ0L2k4y/hDe41vioOb8QLpy82qpe8PoGZDxAhgTI0Zg8IM2LrvmIYWdQ6UpVcl3nQaJmp69f8kO4Q6cIhYNf60A9AA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=c6LKdNoc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="c6LKdNoc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CA35C4CEE3; Fri, 14 Mar 2025 07:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741938592; bh=F2CKtsqXWruFpKjUFngj7uienFU84ae/LFc7ulNmznc=; h=Subject:To:From:Date:From; b=c6LKdNocWwYTmsQcMPNWkyk5dzF9Fkdda49bXSvXXvzVRu7VMoaOJCf4SQ5zzi7Vg C9nSG2NHQbrgRK2RVe1m1FE00o68KgdbsEoQwuDGXRz4uIJZICw5psdnite+iUVgPL TdAcoSEwiF2FWQnItbu0XY5+T3Fcl/7uqLqmx+aI= Subject: patch "iio: adc: ad7768-1: Fix conversion result sign" added to char-misc-next To: sergiu.cuciurean@analog.com,Jonathan.Cameron@huawei.com,Jonathan.Santos@analog.com,Stable@vger.kernel.org,dlechner@baylibre.com,marcelo.schmitt@analog.com From: Date: Fri, 14 Mar 2025 08:40:59 +0100 Message-ID: <2025031459-pasted-obstacle-f4cd@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit This is a note to let you know that I've just added the patch titled iio: adc: ad7768-1: Fix conversion result sign to my char-misc git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git in the char-misc-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. >From 8236644f5ecb180e80ad92d691c22bc509b747bb Mon Sep 17 00:00:00 2001 From: Sergiu Cuciurean Date: Thu, 6 Mar 2025 18:00:29 -0300 Subject: iio: adc: ad7768-1: Fix conversion result sign The ad7768-1 ADC output code is two's complement, meaning that the voltage conversion result is a signed value.. Since the value is a 24 bit one, stored in a 32 bit variable, the sign should be extended in order to get the correct representation. Also the channel description has been updated to signed representation, to match the ADC specifications. Fixes: a5f8c7da3dbe ("iio: adc: Add AD7768-1 ADC basic support") Reviewed-by: David Lechner Reviewed-by: Marcelo Schmitt Signed-off-by: Sergiu Cuciurean Signed-off-by: Jonathan Santos Cc: Link: https://patch.msgid.link/505994d3b71c2aa38ba714d909a68e021f12124c.1741268122.git.Jonathan.Santos@analog.com Signed-off-by: Jonathan Cameron --- drivers/iio/adc/ad7768-1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c index ea829c51e80b..09e7cccfd51c 100644 --- a/drivers/iio/adc/ad7768-1.c +++ b/drivers/iio/adc/ad7768-1.c @@ -142,7 +142,7 @@ static const struct iio_chan_spec ad7768_channels[] = { .channel = 0, .scan_index = 0, .scan_type = { - .sign = 'u', + .sign = 's', .realbits = 24, .storagebits = 32, .shift = 8, @@ -373,7 +373,7 @@ static int ad7768_read_raw(struct iio_dev *indio_dev, iio_device_release_direct(indio_dev); if (ret < 0) return ret; - *val = ret; + *val = sign_extend32(ret, chan->scan_type.realbits - 1); return IIO_VAL_INT; -- 2.48.1