From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A9C71DE8AB; Wed, 19 Mar 2025 14:39:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742395179; cv=none; b=Zi5NxAt5OjvgG5hw1viiPj3lVebqDexeewEVXMkCkBD+Zg4Le/4Z+ajqZoIbIsArvHcUsNAYDurgiN+2vwI7T1VCP8y6i6EKIykb507xI1YX06QMHDlE2HtJVmRe1kb3NZOvghZlM5rAcbNSNCPctX1V2HUodTRmmn8lG4QNzDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742395179; c=relaxed/simple; bh=MbsIFUyYFCEnLht3+evYEyaNn19nDr+kbv7Ql8GptWk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NMqQ+sfqngCqWFYC4BEDUinJeP4QNRjV5Bgn7Qjvq6Vf1JmsLX/0cawuj2hTRQGBwag5I/dyb79tvbkxdsqcGng9ZvurvbHzOa70kphPzmWxQbBDN7MaC1XhJUEK9OgzRNgrlRz0g/mGT5Lq+QEHNcNO5UQtU0Z9gJ55BB3vwa4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Lqspcnlw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Lqspcnlw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F34C0C4CEE8; Wed, 19 Mar 2025 14:39:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1742395179; bh=MbsIFUyYFCEnLht3+evYEyaNn19nDr+kbv7Ql8GptWk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Lqspcnlwxf+1LdBnyIq1Fu1CU4YtagQi+X7yDgp2bXbrd8uFiPn3c8jXL/BmCWf4b J4eATboBlhm9QdQ0p9pJrE3TIKjSMun701qYC0oMmd785IgI3kVzuYgWK0diL3EtV4 7I9otGkLJY/JqIu7L4N5ZtZeUooUqBV3Or76juEY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Michael Kelley , Saurabh Sengar , Wei Liu , Sasha Levin Subject: [PATCH 6.6 008/166] fbdev: hyperv_fb: iounmap() the correct memory when removing a device Date: Wed, 19 Mar 2025 07:29:39 -0700 Message-ID: <20250319143020.206384218@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250319143019.983527953@linuxfoundation.org> References: <20250319143019.983527953@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Michael Kelley [ Upstream commit 7241c886a71797cc51efc6fadec7076fcf6435c2 ] When a Hyper-V framebuffer device is removed, or the driver is unbound from a device, any allocated and/or mapped memory must be released. In particular, MMIO address space that was mapped to the framebuffer must be unmapped. Current code unmaps the wrong address, resulting in an error like: [ 4093.980597] iounmap: bad address 00000000c936c05c followed by a stack dump. Commit d21987d709e8 ("video: hyperv: hyperv_fb: Support deferred IO for Hyper-V frame buffer driver") changed the kind of address stored in info->screen_base, and the iounmap() call in hvfb_putmem() was not updated accordingly. Fix this by updating hvfb_putmem() to unmap the correct address. Fixes: d21987d709e8 ("video: hyperv: hyperv_fb: Support deferred IO for Hyper-V frame buffer driver") Signed-off-by: Michael Kelley Reviewed-by: Saurabh Sengar Link: https://lore.kernel.org/r/20250209235252.2987-1-mhklinux@outlook.com Signed-off-by: Wei Liu Message-ID: <20250209235252.2987-1-mhklinux@outlook.com> Signed-off-by: Sasha Levin --- drivers/video/fbdev/hyperv_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c index b9965cbdd7642..80e8ec36b7db2 100644 --- a/drivers/video/fbdev/hyperv_fb.c +++ b/drivers/video/fbdev/hyperv_fb.c @@ -1106,7 +1106,7 @@ static void hvfb_putmem(struct hv_device *hdev, struct fb_info *info) if (par->need_docopy) { vfree(par->dio_vp); - iounmap(info->screen_base); + iounmap(par->mmio_vp); vmbus_free_mmio(par->mem->start, screen_fb_size); } else { hvfb_release_phymem(hdev, info->fix.smem_start, -- 2.39.5