From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3334221F2E; Wed, 19 Mar 2025 14:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742395246; cv=none; b=XLKH3ZnI+xWqwCoSab9nO72Nwm6xSxtJfEcqqRfykxUl7u8KoQFG+UEdMoEJQSAWrJAIE4mlYTw301CRrNTdKe+onwzMCM1+7oL0u8r7yXj0kPCfI3uZdaL0O0KtdTw/XahCPXmCBl47QCN6Zl/NWXy2he3jFuOMg4V2gGkvf44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742395246; c=relaxed/simple; bh=8/OnQzltoiV+A9uQmXYnL8/VmcssR+2ZDJrOV+CszGM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m2pggK68K+F5lV3GpSGjT22Yb7siI3Y3mozq+hUraWPHzo/tljQFt88WDej1gyHgPs9i8AqqafAjeyvHlTz7As/b5E8Qn6Dc/XjVkpuZS8bF+mh26SOZGdhvIW4kl/hhB0Md2d4C5AJ7ovriNFm4zgBW0OcZ6HRHRbU4Hvi6kro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XPHAh9OG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XPHAh9OG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7C59C4CEE8; Wed, 19 Mar 2025 14:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1742395246; bh=8/OnQzltoiV+A9uQmXYnL8/VmcssR+2ZDJrOV+CszGM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XPHAh9OG2vs12KSL0NVL09J+gXf/1/Y4U+lgwnr4gxlqc+gHrI0u4YhLVyGrUHF2E fipY4fuFwGbm4WKCTN77e5IM1j6k26Y2SBoqw95GLUXu8TYgyc2kCSGEqb2Y5QfpNj 1BTyAH/aYKB4v3rPktfedxg9EbraSRoVO+1WoTEs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alex Deucher , Alex Hung , Mario Limonciello , Tom Chung , Daniel Wheeler Subject: [PATCH 6.6 126/166] drm/amd/display: Fix slab-use-after-free on hdcp_work Date: Wed, 19 Mar 2025 07:31:37 -0700 Message-ID: <20250319143023.427502258@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250319143019.983527953@linuxfoundation.org> References: <20250319143019.983527953@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mario Limonciello commit e65e7bea220c3ce8c4c793b4ba35557f4994ab2b upstream. [Why] A slab-use-after-free is reported when HDCP is destroyed but the property_validate_dwork queue is still running. [How] Cancel the delayed work when destroying workqueue. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4006 Fixes: da3fd7ac0bcf ("drm/amd/display: Update CP property based on HW query") Cc: Alex Deucher Reviewed-by: Alex Hung Signed-off-by: Mario Limonciello Signed-off-by: Tom Chung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher (cherry picked from commit 725a04ba5a95e89c89633d4322430cfbca7ce128) Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c @@ -455,6 +455,7 @@ void hdcp_destroy(struct kobject *kobj, for (i = 0; i < hdcp_work->max_link; i++) { cancel_delayed_work_sync(&hdcp_work[i].callback_dwork); cancel_delayed_work_sync(&hdcp_work[i].watchdog_timer_dwork); + cancel_delayed_work_sync(&hdcp_work[i].property_validate_dwork); } sysfs_remove_bin_file(kobj, &hdcp_work[0].attr);