From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1641720C480; Wed, 19 Mar 2025 14:36:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742395009; cv=none; b=ok12EC3NRZTrzFVJyNNPan4r4379pClbF6VHLNKYSwFbPMnQU3HFjK00pZK9oweqL8ZlVnYpHr0qS+pT4+JEtU2tWkzi2guDj/UhM75ifZt+ulZK4Pu7X49s9rUwBMiCjvKhMJAY98i0SjCgrlue2XLOZEBYb3lWm3B0DS4+z2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742395009; c=relaxed/simple; bh=VlfN7xSnK4Z5V0QcjLjkcf8KBRRHpi/hQobv1vUfQeE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ihh0OH8yf8MReaNjeVJtZ55BVe1P3krPogYIu2IivDGRzW0PzC8o/reT+Jb0SrA9ZhDYhudL3asa0/HPb3hBw2Bo7/2khveZXUE+NWc+eQjT1kOxYoR8FF20RVhc3RO3BYGFguywuUg8YqyXMvEptrt35kZiIBEcMlJfVqrWyl4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=miHFKmgu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="miHFKmgu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E24DCC4CEE4; Wed, 19 Mar 2025 14:36:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1742395009; bh=VlfN7xSnK4Z5V0QcjLjkcf8KBRRHpi/hQobv1vUfQeE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=miHFKmgu35rxenuGjYzzpR6juC/7XUSkSVZJj7I84VcLBSLDyQedLOnucM+/eudCu Ol8obAsfmXsAphUMm0Og5CJAT1THr/yVxTJqCootP94FZauD2gBsnVo3jpSErWUcUZ mM2NsT0bU+3fGZ52JlvuOXqD1PzNVHLX7lryaZnE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jiri Pirko , Kalesh AP , Tariq Toukan , Parav Pandit , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.12 019/231] net/mlx5: Fill out devlink dev info only for PFs Date: Wed, 19 Mar 2025 07:28:32 -0700 Message-ID: <20250319143027.314797415@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250319143026.865956961@linuxfoundation.org> References: <20250319143026.865956961@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiri Pirko [ Upstream commit d749d901b2168389f060b654fdaa08acf6b367d2 ] Firmware version query is supported on the PFs. Due to this following kernel warning log is observed: [ 188.590344] mlx5_core 0000:08:00.2: mlx5_fw_version_query:816:(pid 1453): fw query isn't supported by the FW Fix it by restricting the query and devlink info to the PF. Fixes: 8338d9378895 ("net/mlx5: Added devlink info callback") Signed-off-by: Jiri Pirko Reviewed-by: Kalesh AP Signed-off-by: Tariq Toukan Reviewed-by: Parav Pandit Link: https://patch.msgid.link/20250306212529.429329-1-tariqt@nvidia.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c index 98d4306929f3e..a2cf3e79693dd 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c @@ -46,6 +46,9 @@ mlx5_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req, u32 running_fw, stored_fw; int err; + if (!mlx5_core_is_pf(dev)) + return 0; + err = devlink_info_version_fixed_put(req, "fw.psid", dev->board_id); if (err) return err; -- 2.39.5