From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Hagar Hemdan <hagarhem@amazon.com>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.12] Revert "sched/core: Reduce cost of sched_move_task when config autogroup"
Date: Tue, 25 Mar 2025 07:38:14 -0400 [thread overview]
Message-ID: <20250324210755-fb95f7e2f28e4205@stable.kernel.org> (raw)
In-Reply-To: <20250324114156.31212-1-hagarhem@amazon.com>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: 76f970ce51c80f625eb6ddbb24e9cb51b977b598
WARNING: Author mismatch between patch and upstream commit:
Backport author: Hagar Hemdan<hagarhem@amazon.com>
Commit author: Dietmar Eggemann<dietmar.eggemann@arm.com>
Status in newer kernel trees:
6.13.y | Not found
Note: The patch differs from the upstream commit:
---
1: 76f970ce51c80 ! 1: 1382b2427fdda Revert "sched/core: Reduce cost of sched_move_task when config autogroup"
@@ Metadata
## Commit message ##
Revert "sched/core: Reduce cost of sched_move_task when config autogroup"
+ commit 76f970ce51c80f625eb6ddbb24e9cb51b977b598 upstream.
+
This reverts commit eff6c8ce8d4d7faef75f66614dd20bb50595d261.
Hazem reported a 30% drop in UnixBench spawn test with commit
@@ Commit message
Tested-by: Hagar Hemdan <hagarhem@amazon.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/20250314151345.275739-1-dietmar.eggemann@arm.com
+ Signed-off-by: Hagar Hemdan <hagarhem@amazon.com>
## kernel/sched/core.c ##
@@ kernel/sched/core.c: void sched_release_group(struct task_group *tg)
@@ kernel/sched/core.c: void sched_move_task(struct task_struct *tsk, bool for_auto
-
update_rq_clock(rq);
- running = task_current_donor(rq, tsk);
+ running = task_current(rq, tsk);
@@ kernel/sched/core.c: void sched_move_task(struct task_struct *tsk, bool for_autogroup)
if (running)
put_prev_task(rq, tsk);
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.12.y | Success | Success |
prev parent reply other threads:[~2025-03-25 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 11:41 [PATCH 6.12] Revert "sched/core: Reduce cost of sched_move_task when config autogroup" Hagar Hemdan
2025-03-24 20:51 ` Greg KH
2025-03-25 11:38 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324210755-fb95f7e2f28e4205@stable.kernel.org \
--to=sashal@kernel.org \
--cc=hagarhem@amazon.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox