public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: torvalds@linux-foundation.org, axboe@kernel.dk,
	brauner@kernel.org, clm@meta.com, ct@flyingcircus.io,
	david@fromorbit.com, dhowells@redhat.com, dqminh@cloudflare.com,
	kasong@tencent.com, ryncsn@gmail.com, sam@gentoo.org,
	stable@vger.kernel.org, willy@infradead.org
Subject: Re: [PATCH 6.1.y] Revert "xfs: Support large folios"
Date: Mon, 24 Mar 2025 08:40:18 -0700	[thread overview]
Message-ID: <2025032453-knee-apron-a85e@gregkh> (raw)
In-Reply-To: <20250324030231.14056-1-laoar.shao@gmail.com>

On Mon, Mar 24, 2025 at 11:02:31AM +0800, Yafang Shao wrote:
> This reverts commit 6795801366da0cd3d99e27c37f020a8f16714886.
> 
> Even after resolving the page cache corruption issue [0], problems persist
> with XFS large folios. Recently, we encountered random core dumps in one of
> our Hadoop services. These core dumps occurred sporadically over several
> weeks, and it took significant effort to pinpoint XFS large folios as the
> root cause. After reverting the related commit, the issues disappeared
> entirely. Given these issues, it seems premature to adopt large folios on
> stable kernels. Therefore, we propose reverting this change.
> 
> Link: https://lore.kernel.org/all/20241001210625.95825-1-ryncsn@gmail.com/ [0]
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> ---
>  fs/xfs/xfs_icache.c | 2 --
>  1 file changed, 2 deletions(-)

I need this to be acked by the xfs stable maintainers before I can take
it to the 6.1.y tree.

thanks,

greg k-h

  reply	other threads:[~2025-03-24 15:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-01 21:06 [PATCH 6.1.y 6.6.y 0/3] mm/filemap: fix page cache corruption with large folios Kairui Song
2024-10-01 21:06 ` [PATCH 6.1.y 6.6.y 1/3] mm/filemap: return early if failed to allocate memory for split Kairui Song
2025-03-22 21:51   ` Sasha Levin
2024-10-01 21:06 ` [PATCH 6.1.y 6.6.y 2/3] lib/xarray: introduce a new helper xas_get_order Kairui Song
2025-03-22 21:51   ` Sasha Levin
2024-10-01 21:06 ` [PATCH 6.1.y 6.6.y 3/3] mm/filemap: optimize filemap folio adding Kairui Song
2025-03-22 21:50   ` Sasha Levin
2024-10-02  9:58 ` [PATCH 6.1.y 6.6.y 0/3] mm/filemap: fix page cache corruption with large folios Greg KH
2025-03-22 12:16 ` Yafang Shao
2025-03-22 15:53   ` Linus Torvalds
2025-03-23 11:18     ` Christian Theune
2025-03-23 13:20     ` Yafang Shao
2025-03-24  3:02     ` [PATCH 6.1.y] Revert "xfs: Support large folios" Yafang Shao
2025-03-24 15:40       ` Greg KH [this message]
2025-03-25 11:33       ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025032453-knee-apron-a85e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=clm@meta.com \
    --cc=ct@flyingcircus.io \
    --cc=david@fromorbit.com \
    --cc=dhowells@redhat.com \
    --cc=dqminh@cloudflare.com \
    --cc=kasong@tencent.com \
    --cc=laoar.shao@gmail.com \
    --cc=ryncsn@gmail.com \
    --cc=sam@gentoo.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox