From: "Krzysztof Wilczyński" <kw@linux.com>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
lpieralisi@kernel.org, vigneshr@ti.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
bhelgaas@google.com, rogerq@kernel.org,
linux-omap@vger.kernel.org, linux-pci@vger.kernel.org,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com
Subject: Re: [PATCH] PCI: j721e: Fix the value of linkdown_irq_regfield for J784S4
Date: Wed, 26 Mar 2025 15:54:47 +0900 [thread overview]
Message-ID: <20250326065447.GC2822343@rocinante> (raw)
In-Reply-To: <20250314041705.v5j2fjulol5ywvyq@uda0492258>
Hello,
[...]
> > So I guess without this patch, we incorrectly ignore link-down
> > interrupts on J784S4. It's good to have a one-sentence motivation
> > like that somewhere in the commit log that we can pull out and include
> > in the merge commit log and the pull request.
>
> Yes, we can prepend the following to the existing commit message:
> "Link down interrupts on J784S4 SoC are missed because..."
>
> resulting in the following updated paragraph in the commit message:
> Link down interrupts on J784S4 SoC are missed because commit under Fixes
> assigned the value of 'linkdown_irq_regfield' for the....
How does this look like?
https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/j721e&id=b97b5b8cb603a4ba6b3f7f1b6065fa76e69bdb56
Let me know if you want any changes.
Thank you!
Krzysztof
next prev parent reply other threads:[~2025-03-26 6:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 13:20 [PATCH] PCI: j721e: Fix the value of linkdown_irq_regfield for J784S4 Siddharth Vadapalli
2025-03-10 21:07 ` Krzysztof Wilczyński
2025-03-11 5:18 ` Siddharth Vadapalli
2025-03-11 7:25 ` Krzysztof Wilczyński
2025-03-11 7:32 ` Siddharth Vadapalli
2025-03-11 15:21 ` Krzysztof Wilczyński
2025-03-11 15:29 ` Siddharth Vadapalli
2025-03-11 15:34 ` Krzysztof Wilczyński
2025-03-11 15:00 ` Krzysztof Wilczyński
2025-03-12 16:16 ` Bjorn Helgaas
2025-03-13 5:55 ` Siddharth Vadapalli
2025-03-13 16:02 ` Bjorn Helgaas
2025-03-14 4:17 ` Siddharth Vadapalli
2025-03-26 6:54 ` Krzysztof Wilczyński [this message]
2025-03-26 7:01 ` Siddharth Vadapalli
2025-03-26 7:08 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250326065447.GC2822343@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox