From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B3A925F967; Thu, 3 Apr 2025 19:20:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743708017; cv=none; b=qv/rJwE1Trm6RWVkpDUuumg67nxlRjB/cWbUox/uBPaZxmeew0wZZQTwvbxKFxaMRNa6vUpNVb31XeMOcJr2KBx4dZ+xXBabBCJn7bQUNvsgb2mQfOHUK5enkqbAJOUTkbMuWoEMR4Z+3YhbQVCW0Dx7vay243GWocKHVzDgya8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743708017; c=relaxed/simple; bh=Aukq3tmQCLJmA1gdRb8cjrzyv0lX691slKjdUWkiyqo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EIZfAEtDLE/nQyFjfHwZM3fIUgk0xc9roDIvkcUMgnWufDldM6D18aAl4F9G/Npuf3dnN586B49OvibxTEqTnM/U3wwD7HCDKOBvIP99z2RaRGsUo3KI/iC24tVYvES0B2BOIJ8GuEDICWuz5kFw/5Ya2NDAAPhpCsTY8iPOKNg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kWjLylvT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kWjLylvT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAFEDC4CEE3; Thu, 3 Apr 2025 19:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743708017; bh=Aukq3tmQCLJmA1gdRb8cjrzyv0lX691slKjdUWkiyqo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kWjLylvTQJh/MpjWThCt+bfwr4JYTSLwsC/SKfZ9ODSFQxr3w2yVpjYppiEQiG09K fV4Rf8KRJf8ajIHXsn6NuuVEL3WWD7JBQuSY1k6w2qHllX2T6sV4IzRCf5tjw+qoO7 JUTtmUuuLtN3LtDXsVbPmyerizNOHwh7Aj1woauzwbOn/597TYovJt/QO26VGRJ7a0 njZmn7JGXtSTE3bPwdhin41w0ZVhzPYDa9CAJ1tsmiuM5fWTPVw1gxS4Q3f11XpqxE 9/p9GTUUASdhArz4fLWekn7wdTJ3hi8YB8Vc3ciJxO45WKP4vXybfbHFk4qdG2Mmy4 lAAsQ/u+Mv5vg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Luca Ceresoli , Dmitry Baryshkov , Robert Foss , Sasha Levin , neil.armstrong@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.15 05/12] drm/bridge: panel: forbid initializing a panel with unknown connector type Date: Thu, 3 Apr 2025 15:19:54 -0400 Message-Id: <20250403192001.2682149-5-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250403192001.2682149-1-sashal@kernel.org> References: <20250403192001.2682149-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.179 Content-Transfer-Encoding: 8bit From: Luca Ceresoli [ Upstream commit b296955b3a740ecc8b3b08e34fd64f1ceabb8fb4 ] Having an DRM_MODE_CONNECTOR_Unknown connector type is considered bad, and drm_panel_bridge_add_typed() and derivatives are deprecated for this. drm_panel_init() won't prevent initializing a panel with a DRM_MODE_CONNECTOR_Unknown connector type. Luckily there are no in-tree users doing it, so take this as an opportinuty to document a valid connector type must be passed. Returning an error if this rule is violated is not possible because drm_panel_init() is a void function. Add at least a warning to make any violations noticeable, especially to non-upstream drivers. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Ceresoli Signed-off-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/20250214-drm-assorted-cleanups-v7-5-88ca5827d7af@bootlin.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/drm_panel.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c index 7fd3de89ed079..acd29b4f43f84 100644 --- a/drivers/gpu/drm/drm_panel.c +++ b/drivers/gpu/drm/drm_panel.c @@ -49,7 +49,7 @@ static LIST_HEAD(panel_list); * @dev: parent device of the panel * @funcs: panel operations * @connector_type: the connector type (DRM_MODE_CONNECTOR_*) corresponding to - * the panel interface + * the panel interface (must NOT be DRM_MODE_CONNECTOR_Unknown) * * Initialize the panel structure for subsequent registration with * drm_panel_add(). @@ -57,6 +57,9 @@ static LIST_HEAD(panel_list); void drm_panel_init(struct drm_panel *panel, struct device *dev, const struct drm_panel_funcs *funcs, int connector_type) { + if (connector_type == DRM_MODE_CONNECTOR_Unknown) + DRM_WARN("%s: %s: a valid connector type is required!\n", __func__, dev_name(dev)); + INIT_LIST_HEAD(&panel->list); panel->dev = dev; panel->funcs = funcs; -- 2.39.5