From: Greg KH <gregkh@linuxfoundation.org>
To: Ryo Takakura <ryotkkr98@gmail.com>
Cc: alex@ghiti.fr, aou@eecs.berkeley.edu, bigeasy@linutronix.de,
conor.dooley@microchip.com, jirislaby@kernel.org,
john.ogness@linutronix.de, palmer@dabbelt.com,
paul.walmsley@sifive.com, pmladek@suse.com,
samuel.holland@sifive.com, u.kleine-koenig@baylibre.com,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-serial@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v4 1/2] serial: sifive: lock port in startup()/shutdown() callbacks
Date: Sat, 5 Apr 2025 08:35:44 +0100 [thread overview]
Message-ID: <2025040553-video-declared-7d54@gregkh> (raw)
In-Reply-To: <20250405044338.397237-1-ryotkkr98@gmail.com>
On Sat, Apr 05, 2025 at 01:43:38PM +0900, Ryo Takakura wrote:
> startup()/shutdown() callbacks access SIFIVE_SERIAL_IE_OFFS.
> The register is also accessed from write() callback.
>
> If console were printing and startup()/shutdown() callback
> gets called, its access to the register could be overwritten.
>
> Add port->lock to startup()/shutdown() callbacks to make sure
> their access to SIFIVE_SERIAL_IE_OFFS is synchronized against
> write() callback.
>
> Signed-off-by: Ryo Takakura <ryotkkr98@gmail.com>
> Cc: stable@vger.kernel.org
What commit id does this fix?
Why does patch 1/2 need to go to stable, but patch 2/2 does not? Please
do not mix changes like this in the same series, otherwise we have to
split them up manually when we apply them to the different branches,
right?
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-05 7:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250405043833.397020-1-ryotkkr98@gmail.com>
2025-04-05 4:43 ` [PATCH v4 1/2] serial: sifive: lock port in startup()/shutdown() callbacks Ryo Takakura
2025-04-05 7:35 ` Greg KH [this message]
2025-04-05 11:23 ` Ryo Takakura
2025-04-22 10:20 ` Vlastimil Babka
2025-04-22 10:50 ` Greg KH
2025-04-22 13:07 ` Vlastimil Babka
2025-04-22 13:16 ` Greg KH
2025-04-25 9:02 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025040553-video-declared-7d54@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=bigeasy@linutronix.de \
--cc=conor.dooley@microchip.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pmladek@suse.com \
--cc=ryotkkr98@gmail.com \
--cc=samuel.holland@sifive.com \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox