From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <horms@kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>,
<ematsumiya@suse.de>, <kuba@kernel.org>, <kuni1840@gmail.com>,
<kuniyu@amazon.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>, <peterz@infradead.org>, <sfrench@samba.org>,
<stable@vger.kernel.org>, <wangzhaolong1@huawei.com>,
<willemb@google.com>
Subject: Re: [PATCH v2 net] net: Fix null-ptr-deref by sock_lock_init_class_and_name() and rmmod.
Date: Mon, 7 Apr 2025 08:46:18 -0700 [thread overview]
Message-ID: <20250407154623.15542-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250407104559.GB395307@horms.kernel.org>
From: Simon Horman <horms@kernel.org>
Date: Mon, 7 Apr 2025 11:45:59 +0100
> > diff --git a/include/net/sock.h b/include/net/sock.h
> > index 8daf1b3b12c6..4216d7d86150 100644
> > --- a/include/net/sock.h
> > +++ b/include/net/sock.h
> > @@ -547,6 +547,10 @@ struct sock {
> > struct rcu_head sk_rcu;
> > netns_tracker ns_tracker;
> > struct xarray sk_user_frags;
> > +
> > +#if IS_ENABLED(CONFIG_PROVE_LOCKING) && IS_ENABLED(CONFIG_MODULES)
> > + struct module *sk_owner;
> > +#endif
>
> Not a proper review, but FWIIW, sk_owner should be added to the Kernel doc
> for struct sock.
Thanks for catching!
Will add kdoc in v3.
next prev parent reply other threads:[~2025-04-07 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 20:34 [PATCH v2 net] net: Fix null-ptr-deref by sock_lock_init_class_and_name() and rmmod Kuniyuki Iwashima
2025-04-07 10:45 ` Simon Horman
2025-04-07 15:46 ` Kuniyuki Iwashima [this message]
2025-04-07 11:21 ` Eric Dumazet
2025-04-07 15:52 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407154623.15542-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ematsumiya@suse.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=sfrench@samba.org \
--cc=stable@vger.kernel.org \
--cc=wangzhaolong1@huawei.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox