From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78961258CCE; Mon, 7 Apr 2025 18:12:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744049532; cv=none; b=szr8e0ulV5ea5dtvu+Q/3T45kRIaolA1ReGj8e0ZeC1N/uUiso8Y62t4RudRRAzK5D1ccidZ6JbhEP0cJsLn3wkQGP01JLPiOf8fnrJ0RZP/d5UK//Z+Kpq99ip2+3bwkD7kxfe58kx7ylITFFUymThWl6MuvMerEAxUqayMiN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744049532; c=relaxed/simple; bh=5W84jrrsi57Rg74JY/htU6D5Jhn3vViqZCPs02B1xQo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=U/RqkEj8PGdZUYRcsv4T/pftLqteWPDRmJwNWLlDDnDTVZVGGdGDrJmwJpHU2ktnhB50l3wWoaVdIh6S2RxfiV/F8ExNquCDlz/fA/O52xGN4Y3Y3u/TEdNAehF5uOoX9yy6xcFCmu+mq2S1jpOZyVG5wkymNgO0oNgrgeRsYOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Jy829Jcj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jy829Jcj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A751BC4CEDD; Mon, 7 Apr 2025 18:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744049532; bh=5W84jrrsi57Rg74JY/htU6D5Jhn3vViqZCPs02B1xQo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jy829JcjNhiJWBMJJplB5RT1sitzLorSJnTbQk5gWnobWiJQeghaJgjTp7drCXl3G 1EXmWCNISg4IY8NsJSlaWEBiDmFfmxvI2Bzx+i+kfQdjS6cd6VAtIftHdsbB7mdqbf YtHRiMoo9GxjbuMtLNs+FcNHxVW0SxFULEy2UiaktpuUSbVgbsJYPV6FYRDFa9NAt5 xOwh6HWJTEO9VXPjnh1cWF36ZzpE7QrjSn8BU4uQIQ2wu+KbEmmompTxEZ3ALVHxOy Gt80B5YExOHeK9MSzHn4b/Et5Bh5OUYS3QpOp/sSOMb008vpQIKsRI2XvdS4wdCctp +PSFc7iv7yQdg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Josh Poimboeuf , Ingo Molnar , Kees Cook , Andrew Morton , Linus Torvalds , Sasha Levin , peterz@infradead.org, pmladek@suse.com, jani.nikula@intel.com, gregkh@linuxfoundation.org, john.ogness@linutronix.de, joel.granados@kernel.org, jfalempe@redhat.com, takakura@valinux.co.jp Subject: [PATCH AUTOSEL 6.14 28/31] objtool, panic: Disable SMAP in __stack_chk_fail() Date: Mon, 7 Apr 2025 14:10:44 -0400 Message-Id: <20250407181054.3177479-28-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250407181054.3177479-1-sashal@kernel.org> References: <20250407181054.3177479-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14.1 Content-Transfer-Encoding: 8bit From: Josh Poimboeuf [ Upstream commit 72c774aa9d1e16bfd247096935e7dae194d84929 ] __stack_chk_fail() can be called from uaccess-enabled code. Make sure uaccess gets disabled before calling panic(). Fixes the following warning: kernel/trace/trace_branch.o: error: objtool: ftrace_likely_update+0x1ea: call to __stack_chk_fail() with UACCESS enabled Signed-off-by: Josh Poimboeuf Signed-off-by: Ingo Molnar Cc: Kees Cook Cc: Andrew Morton Cc: Linus Torvalds Link: https://lore.kernel.org/r/a3e97e0119e1b04c725a8aa05f7bc83d98e657eb.1742852847.git.jpoimboe@kernel.org Signed-off-by: Sasha Levin --- kernel/panic.c | 6 ++++++ tools/objtool/check.c | 5 ++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/kernel/panic.c b/kernel/panic.c index d8635d5cecb25..f9f0c5148f6aa 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -832,9 +832,15 @@ device_initcall(register_warn_debugfs); */ __visible noinstr void __stack_chk_fail(void) { + unsigned long flags; + instrumentation_begin(); + flags = user_access_save(); + panic("stack-protector: Kernel stack is corrupted in: %pB", __builtin_return_address(0)); + + user_access_restore(flags); instrumentation_end(); } EXPORT_SYMBOL(__stack_chk_fail); diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 9b5852299957e..192554116f5d8 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1188,12 +1188,15 @@ static const char *uaccess_safe_builtin[] = { "__ubsan_handle_load_invalid_value", /* STACKLEAK */ "stackleak_track_stack", + /* TRACE_BRANCH_PROFILING */ + "ftrace_likely_update", + /* STACKPROTECTOR */ + "__stack_chk_fail", /* misc */ "csum_partial_copy_generic", "copy_mc_fragile", "copy_mc_fragile_handle_tail", "copy_mc_enhanced_fast_string", - "ftrace_likely_update", /* CONFIG_TRACE_BRANCH_PROFILING */ "rep_stos_alternative", "rep_movs_alternative", "__copy_user_nocache", -- 2.39.5