From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1334E268FDE; Tue, 8 Apr 2025 12:04:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744113890; cv=none; b=Gxtu+BraTxLJkkwVe81QkGT99pPMcHctOcDrmdP2Q8IcVtmJAJl+2hiqOT44YBsAeVeCVlS0D2OXqycCs4fhbuDbi4sD1vwkUzHgngOoNhIjuN/m37g3QEjOYa58e36PVX+nLzqjTiQKjJQGZXJE1d4GZilRXVBT9nqM1LxeCHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744113890; c=relaxed/simple; bh=muSHZYIGx4Dav3bxxFwBKjaiQkq8T4nYDmpoLpJLREw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IV6rPD+Pov4lba5veExtjTFaAJ5DNiNP4ZJH2IBcbsdC/xzrdt7Au7jF3WSGkhLGaYP88qtAjLsdL7uGX/JKij3SMT/xCMUS734oYN6V+6UvAExQxe6YKW3DG9ga2XGU5CHKy0OERdNhvBd/+ZhYqGIbQIL8XvtcMtVym6ImQwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NnsrczYQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NnsrczYQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B33EC4CEE5; Tue, 8 Apr 2025 12:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744113890; bh=muSHZYIGx4Dav3bxxFwBKjaiQkq8T4nYDmpoLpJLREw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NnsrczYQjKE3LaVx/NdO50C7NrX+IkjMPO6T9cprkoCwZp+m/Vv2C5VYKG7lpIbK8 q14NDE0LGrLcRjSvZUX3cgN8/4FHGXuq5deW9vsaTK4KQxmSP65aAPgifSHQvihvlD 00OmP6tj6W0Z3fPrVSYUW6eDz+TErvBPK3rVZ4bU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kuniyuki Iwashima , David Ahern , Paolo Abeni , Sasha Levin Subject: [PATCH 5.4 057/154] ipv6: Set errno after ip_fib_metrics_init() in ip6_route_info_create(). Date: Tue, 8 Apr 2025 12:49:58 +0200 Message-ID: <20250408104817.113975840@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104815.295196624@linuxfoundation.org> References: <20250408104815.295196624@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kuniyuki Iwashima [ Upstream commit 9a81fc3480bf5dbe2bf80e278c440770f6ba2692 ] While creating a new IPv6, we could get a weird -ENOMEM when RTA_NH_ID is set and either of the conditions below is true: 1) CONFIG_IPV6_SUBTREES is enabled and rtm_src_len is specified 2) nexthop_get() fails e.g.) # strace ip -6 route add fe80::dead:beef:dead:beef nhid 1 from :: recvmsg(3, {msg_iov=[{iov_base=[...[ {error=-ENOMEM, msg=[... [...]]}, [{nla_len=49, nla_type=NLMSGERR_ATTR_MSG}, "Nexthops can not be used with so"...] ]], iov_len=32768}], msg_iovlen=1, msg_controllen=0, msg_flags=0}, 0) = 148 Let's set err explicitly after ip_fib_metrics_init() in ip6_route_info_create(). Fixes: f88d8ea67fbd ("ipv6: Plumb support for nexthop object in a fib6_info") Signed-off-by: Kuniyuki Iwashima Reviewed-by: David Ahern Link: https://patch.msgid.link/20250312013854.61125-1-kuniyu@amazon.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/ipv6/route.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index d037979f6579f..b321cec711270 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -3729,10 +3729,12 @@ static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg, if (nh) { if (rt->fib6_src.plen) { NL_SET_ERR_MSG(extack, "Nexthops can not be used with source routing"); + err = -EINVAL; goto out_free; } if (!nexthop_get(nh)) { NL_SET_ERR_MSG(extack, "Nexthop has been deleted"); + err = -ENOENT; goto out_free; } rt->nh = nh; -- 2.39.5