From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43F4CA94A; Tue, 8 Apr 2025 12:06:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744114007; cv=none; b=V2A0atmsxxbV89t8u51T7o0B9cOmd6TyTo9NJX6iPg5iHKPspBz4zBh11u1D1bBkX7a3v/gVRj1Qr8baZnyxjUMvymJ2rK9JJB5L0U6KOtZRW9RX5OohappeIqv2BP5P1Fq1lkRo9RAMQQUpoHQK7zHZ2Q52HQbIDZybvPCoWCw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744114007; c=relaxed/simple; bh=FoWxCH7f05QcfmqNCZ7WLczYGqX5EowUPH74MWiYRJ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WqL0B6khTslfBkdQ0l+EzOZoxhqCUn0gk/mx+M8/VNIw5vle2So8Dp5tX+ZBjAI03PJOyx0bkYoeZFiYFEVTHYwNu5eeIzP835+bkPXIfR9sqEjlxLLrXPfbwBfPi0069jPQDzj9ybzJceRtfO+bKFMVf3bud9L3bELTOe/qKBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Nme5Uvrs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Nme5Uvrs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5DB3C4CEE5; Tue, 8 Apr 2025 12:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744114007; bh=FoWxCH7f05QcfmqNCZ7WLczYGqX5EowUPH74MWiYRJ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nme5Uvrs9TmdsLL/LvfsZxAKDIB777He4f6jWXo5Av1SJNW6Cx50drpJabJtMyuQY DlUu8/lfixlxnTvofRH5VXzMz737Rd86a7aY6Lkd3r4pi3g5OC5G9SocRsNL7RkM0x kce4RX9tscy6oVKA/qGwptS3EztaKJnxpRU6EFkU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Neil Armstrong , Jerome Brunet , Sasha Levin Subject: [PATCH 5.4 101/154] clk: amlogic: gxbb: drop incorrect flag on 32k clock Date: Tue, 8 Apr 2025 12:50:42 +0200 Message-ID: <20250408104818.567389343@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104815.295196624@linuxfoundation.org> References: <20250408104815.295196624@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jerome Brunet [ Upstream commit f38f7fe4830c5cb4eac138249225f119e7939965 ] gxbb_32k_clk_div sets CLK_DIVIDER_ROUND_CLOSEST in the init_data flag which is incorrect. This is field is not where the divider flags belong. Thankfully, CLK_DIVIDER_ROUND_CLOSEST maps to bit 4 which is an unused clock flag, so there is no unintended consequence to this error. Effectively, the clock has been used without CLK_DIVIDER_ROUND_CLOSEST so far, so just drop it. Fixes: 14c735c8e308 ("clk: meson-gxbb: Add EE 32K Clock for CEC") Reviewed-by: Neil Armstrong Link: https://lore.kernel.org/r/20241220-amlogic-clk-gxbb-32k-fixes-v1-1-baca56ecf2db@baylibre.com Signed-off-by: Jerome Brunet Signed-off-by: Sasha Levin --- drivers/clk/meson/gxbb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c index e8e36ec70b27f..f37b763f7c48b 100644 --- a/drivers/clk/meson/gxbb.c +++ b/drivers/clk/meson/gxbb.c @@ -1305,7 +1305,7 @@ static struct clk_regmap gxbb_32k_clk_div = { &gxbb_32k_clk_sel.hw }, .num_parents = 1, - .flags = CLK_SET_RATE_PARENT | CLK_DIVIDER_ROUND_CLOSEST, + .flags = CLK_SET_RATE_PARENT, }, }; -- 2.39.5