From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1F0B268685; Tue, 8 Apr 2025 12:07:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744114065; cv=none; b=cAa9dwDrZrgTnIo+Og/FKkupIAFPkVFQPogzHuThsWNnZ4nWVnU461QxWR/YGRXlzYwUq6dTJ8WYs9Y5Yh/kX0/J55JSEqRmmddNrjzVphIlB/BU5W1mNcwCMcmE5c5BeCABMyiS3vQvEbswYk3d+zRsalXNTDTUEwA94FgAtG8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744114065; c=relaxed/simple; bh=w3IdBMCkYdTyB+kSgQQZ/mBtpHTTif5M0L7S6dkNPZU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l/S0V+n+N+tGoQmoB69oPDiZbID7S5eLZWBB9nRVmKiqg56xQv2TMbW1WZrjNyqwxfWwtNqr+hezJRHs5FZTE24c85Cm6Wcod2D9l9MbGkulfsptZGjMXPcrEheqyqNTd6ExGHOCYBj1jeBO756gTqB4kIgber4Xny9SKPtZLeo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XgSLbs6S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XgSLbs6S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B954EC4CEE5; Tue, 8 Apr 2025 12:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744114065; bh=w3IdBMCkYdTyB+kSgQQZ/mBtpHTTif5M0L7S6dkNPZU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XgSLbs6SuW7nzYMNVYI3UsU4ZpoCjd4EJS4LUZ1BfqpvGMJbEW/Ypu0ZHEu0VHaX9 JrcrxmzyBt6/gI3PZvdqN9SV8QM2twY3H/eS0rjK8kzMTn07OvJQMp4YMkbyJVukLr 3LbQf5/VRFg/EumjKmN1LG4rn3eK9u/XUnlmKtTc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bart Van Assche , Kees Cook , "Eric W. Biederman" , Alexey Dobriyan , Andrew Morton , Sasha Levin Subject: [PATCH 5.4 124/154] fs/procfs: fix the comment above proc_pid_wchan() Date: Tue, 8 Apr 2025 12:51:05 +0200 Message-ID: <20250408104819.286504090@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104815.295196624@linuxfoundation.org> References: <20250408104815.295196624@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bart Van Assche [ Upstream commit 6287fbad1cd91f0c25cdc3a580499060828a8f30 ] proc_pid_wchan() used to report kernel addresses to user space but that is no longer the case today. Bring the comment above proc_pid_wchan() in sync with the implementation. Link: https://lkml.kernel.org/r/20250319210222.1518771-1-bvanassche@acm.org Fixes: b2f73922d119 ("fs/proc, core/debug: Don't expose absolute kernel addresses via wchan") Signed-off-by: Bart Van Assche Cc: Kees Cook Cc: Eric W. Biederman Cc: Alexey Dobriyan Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- fs/proc/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index 34e15da39fdf3..d785d148e15f3 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -413,7 +413,7 @@ static const struct file_operations proc_pid_cmdline_ops = { #ifdef CONFIG_KALLSYMS /* * Provides a wchan file via kallsyms in a proper one-value-per-file format. - * Returns the resolved symbol. If that fails, simply return the address. + * Returns the resolved symbol to user space. */ static int proc_pid_wchan(struct seq_file *m, struct pid_namespace *ns, struct pid *pid, struct task_struct *task) -- 2.39.5