From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55D251AAA32; Tue, 8 Apr 2025 12:33:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744115589; cv=none; b=U9DIhMu1Tsqsiuizrl/ehrBbbw45jBSKG5S8e3fxloc2oNbA9Zra2XBGnPM3zrR+/nAfe4E/RsdiaM5UwYU2t8/rHFvAgwq3UyF2Dnag9Z40wgEFdPm/4T1gd6hPfW/fTL/7G/b/ChwWVRo6VCwuj7ZFsmQmwWlhoz1ncFy8QZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744115589; c=relaxed/simple; bh=jk22wYgqRx0kTbWJxhNk9M/brQD8jTlh4nEAaI9nahs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RLUC4hdMQrxRC+Os/85iMT1q5N7efq7kol6D/EGvCkIbT0MLM+7uNjF1dHNw57rgdAvF88uC0OHWAkE6U0p1ruY2Wy2nUebUf3+OteczcU+gA2o432/hKIL+GVligbOJs8/5GzXIDtHjvfayb17igv4CQPBzn1kLe68hZqOPeUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=c853TnbB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="c853TnbB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9FE6C4CEE5; Tue, 8 Apr 2025 12:33:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744115589; bh=jk22wYgqRx0kTbWJxhNk9M/brQD8jTlh4nEAaI9nahs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c853TnbBYx/puZ2eyukLz382juB5KCD6qhvo98VgtslUxTX815oUtROfSjXUXEBcP sFra8mwzO2dcxtP8YE9JzXCIpxRLwGMtJ9oJVPuJu44tSDXoDeWjhk7A0NxSiEpYeE Q21mgyjgUcVzp81zMEwpgZj/8dOWqAuOSh3DZASc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, zuoqian , Dan Carpenter , Viresh Kumar , Sasha Levin Subject: [PATCH 6.1 003/204] cpufreq: scpi: compare kHz instead of Hz Date: Tue, 8 Apr 2025 12:48:53 +0200 Message-ID: <20250408104820.380417461@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104820.266892317@linuxfoundation.org> References: <20250408104820.266892317@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: zuoqian [ Upstream commit 4742da9774a416908ef8e3916164192c15c0e2d1 ] The CPU rate from clk_get_rate() may not be divisible by 1000 (e.g., 133333333). But the rate calculated from frequency(kHz) is always divisible by 1000 (e.g., 133333000). Comparing the rate causes a warning during CPU scaling: "cpufreq: __target_index: Failed to change cpu frequency: -5". When we choose to compare kHz here, the issue does not occur. Fixes: 343a8d17fa8d ("cpufreq: scpi: remove arm_big_little dependency") Signed-off-by: zuoqian Reviewed-by: Dan Carpenter Signed-off-by: Viresh Kumar Signed-off-by: Sasha Levin --- drivers/cpufreq/scpi-cpufreq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c index ac719aca49b75..433deec4b61f8 100644 --- a/drivers/cpufreq/scpi-cpufreq.c +++ b/drivers/cpufreq/scpi-cpufreq.c @@ -39,8 +39,9 @@ static unsigned int scpi_cpufreq_get_rate(unsigned int cpu) static int scpi_cpufreq_set_target(struct cpufreq_policy *policy, unsigned int index) { - u64 rate = policy->freq_table[index].frequency * 1000; + unsigned long freq_khz = policy->freq_table[index].frequency; struct scpi_data *priv = policy->driver_data; + unsigned long rate = freq_khz * 1000; int ret; ret = clk_set_rate(priv->clk, rate); @@ -48,7 +49,7 @@ scpi_cpufreq_set_target(struct cpufreq_policy *policy, unsigned int index) if (ret) return ret; - if (clk_get_rate(priv->clk) != rate) + if (clk_get_rate(priv->clk) / 1000 != freq_khz) return -EIO; return 0; -- 2.39.5