From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EDEE26B0A2; Tue, 8 Apr 2025 12:39:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744115984; cv=none; b=Fs5kDsEls5ACna+gXJ1aFhr+ULcKXn/hCn1V3ayW8ArZK09UWw6ADE7bwIQ1yP9okJkvGpLxwoUNmvwyD59lJaLuPA/j1IyRc7J8sAcxTjx5w/hHrZMUVLvfSotsbUOEqBHyMo92ZNwbvtBSSqDLOIx+EeT2uAfev9rJbqfwQDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744115984; c=relaxed/simple; bh=zZggAXfr+PmCMGLhtXznHb+CAIt4BK2WcPaDKWI3gTE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sdR0GBY3lybcN2B3Eb1/36oTTVL1BdUn73BLgC9lmQhwAQkBEo0+N1ZvwDXNrBwzThs+KAxkN41mVRxdFDrCn8MZj3AOTrcT2ZOPKxKf5gnHZeZ6wajL1vZ8XutKmhKoLx/Yjo11e+3ajq/nsE2qYaLxOuqQ74xU5/isDuuKCuI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WcPCJyyw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WcPCJyyw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82A99C4CEE5; Tue, 8 Apr 2025 12:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744115983; bh=zZggAXfr+PmCMGLhtXznHb+CAIt4BK2WcPaDKWI3gTE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WcPCJyywvg4/bFq/z9qLDIPhTPtSBU3kgVdQ3QP4CzsSn2wEG/tnDFeBpxD+UAjxC ZBXREg1iPR29hgXpBCE9J1gPJymdOiLtI5ES+dftoGoXNb1iHdNBrer9r+F939wXnL 71qJhljP4atduv8nnQLXFXFVkf2LtVcw40x7LxAc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Srinivas Pandruvada , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH 6.1 177/204] platform/x86: ISST: Correct command storage data length Date: Tue, 8 Apr 2025 12:51:47 +0200 Message-ID: <20250408104825.513538357@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408104820.266892317@linuxfoundation.org> References: <20250408104820.266892317@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Srinivas Pandruvada commit 9462e74c5c983cce34019bfb27f734552bebe59f upstream. After resume/online turbo limit ratio (TRL) is restored partially if the admin explicitly changed TRL from user space. A hash table is used to store SST mail box and MSR settings when modified to restore those settings after resume or online. This uses a struct isst_cmd field "data" to store these settings. This is a 64 bit field. But isst_store_new_cmd() is only assigning as u32. This results in truncation of 32 bits. Change the argument to u64 from u32. Fixes: f607874f35cb ("platform/x86: ISST: Restore state on resume") Signed-off-by: Srinivas Pandruvada Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20250328224749.2691272-1-srinivas.pandruvada@linux.intel.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c @@ -77,7 +77,7 @@ static DECLARE_HASHTABLE(isst_hash, 8); static DEFINE_MUTEX(isst_hash_lock); static int isst_store_new_cmd(int cmd, u32 cpu, int mbox_cmd_type, u32 param, - u32 data) + u64 data) { struct isst_cmd *sst_cmd;